Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error returned from DbCryptPlugin::setKey() is not shown [CORE5793] #6056

Closed
firebird-issue-importer opened this issue Apr 15, 2018 · 6 comments

Comments

@firebird-issue-importer

Submitted by: @aafemt

Meaningless error text "Missing correct crypt key" is returned to application in this case. It makes diagnostic of a problem harder than necessary.
I'd suggest to append status returned from plugin to the end of message.

Commits: 76347ed f97bb71

@firebird-issue-importer
Copy link
Author

firebird-issue-importer commented May 10, 2018

Modified by: @AlexPeshkoff

assignee: Alexander Peshkov [ alexpeshkoff ]

@firebird-issue-importer
Copy link
Author

firebird-issue-importer commented May 10, 2018

Commented by: @AlexPeshkoff

Minor problem - I there are >1 KeyHolder plugin and all failed what status vector should I return?
IStatus can fit them all - but would it be good diags:

Missing correct crypt key
-Plugin ABC:
-Incorrect key format
-Plugin XXX:
-some more error

and so on?

@firebird-issue-importer
Copy link
Author

firebird-issue-importer commented May 10, 2018

Commented by: @aafemt

Configuration with more than one keyholder for a database is meaningless as Vlad said years ago. No mater if the first of the last error is shown in this case.

@firebird-issue-importer
Copy link
Author

firebird-issue-importer commented Aug 29, 2018

Modified by: @AlexPeshkoff

status: Open [ 1 ] => Resolved [ 5 ]

resolution: Fixed [ 1 ]

Fix Version: 4.0 Beta 1 [ 10750 ]

Fix Version: 3.0.4 [ 10863 ]

@firebird-issue-importer
Copy link
Author

firebird-issue-importer commented Jun 10, 2019

Modified by: @pavel-zotov

status: Resolved [ 5 ] => Resolved [ 5 ]

QA Status: No test => Done successfully

@firebird-issue-importer
Copy link
Author

firebird-issue-importer commented Jun 10, 2019

Modified by: @pavel-zotov

status: Resolved [ 5 ] => Closed [ 6 ]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment