Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rotated Trace files locked by engine [CORE5838] #6099

Closed
firebird-issue-importer opened this issue May 31, 2018 · 12 comments
Closed

Rotated Trace files locked by engine [CORE5838] #6099

firebird-issue-importer opened this issue May 31, 2018 · 12 comments

Comments

@firebird-issue-importer

Submitted by: Sergey Borisov (bsv)

Attachments:
screenshot.PNG

Firebird 3.0.4 Classic on Windows OS running with system trace audit with log rotation param max_log_size = 50.

For many rotated files (not all) the engine still has a lock of the file, so they can not be opened for viewing. Within 6 hours we have 8 such files.

Commits: 27e4264

====== Test Details ======

Can not be implemented using current fbtest package: we have no ability to restart FB during tests for turning on/off system audit.
Probably will be implemented after developing additional batch scenario for this.

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented May 31, 2018

Commented by: @hvlad

Could you confirm that all such files are locked by idle Firebird Classic processes ?

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented May 31, 2018

Modified by: @hvlad

assignee: Vlad Khorsun [ hvlad ]

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented May 31, 2018

Commented by: Sergey Borisov (bsv)

Yes, look the screenshot.
Firebird PID=2512 lock file fb_trace.2018-05-31T12-11-06.log.

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented May 31, 2018

Modified by: Sergey Borisov (bsv)

Attachment: screenshot.PNG [ 13256 ]

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented May 31, 2018

Commented by: @hvlad

Are you sure PID 2512 is idle ?

You may check it using monitoring tables.

Also, what happens with fb_trace.2018-05-31T12-11-06.log file when any audited event occurs in
attachment handled by PID 2512 (no need to disconnect it, just run some query, etc) ?

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented May 31, 2018

Commented by: Sergey Borisov (bsv)

Yes, PID 2512 was in idle.
select A.Mon$state from mon$attachments A Where A.mon$server_pid in (2512)
return 0.

After running query and commiting transaction on that connection (PID 2512) , the lock disappeared.

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented May 31, 2018

Commented by: @hvlad

Thank for confirmation

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented May 31, 2018

Commented by: Sean Leyne (seanleyne)

Edited to clarify issue

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented May 31, 2018

Modified by: Sean Leyne (seanleyne)

description: Firebird 3.0.4 Classic on Windows OS runed with system trace audit with log rotation param max_log_size = 50.
Many rotated files (not all) is locked by firebird so, that it can not be opened for viewing. Within 6 hours we have 8 such files.

=>

Firebird 3.0.4 Classic on Windows OS running with system trace audit with log rotation param max_log_size = 50.

For many rotated files (not all) the engine still has a lock of the file, so they can not be opened for viewing. Within 6 hours we have 8 such files.

summary: Trace files monopoly locked by firebird => Rotated Trace files locked by engine

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented May 19, 2020

Commented by: @hvlad

Fix is committed into v4.
Tested on Windows mostly, please test it carefully.

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Jun 11, 2020

Modified by: @hvlad

status: Open [ 1 ] => Resolved [ 5 ]

resolution: Fixed [ 1 ]

Fix Version: 4.0 RC 1 [ 10930 ]

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Jun 15, 2020

Modified by: @pavel-zotov

status: Resolved [ 5 ] => Resolved [ 5 ]

QA Status: No test => Deferred

Test Details: Can not be implemented using current fbtest package: we have no ability to restart FB during tests for turning on/off system audit.
Probably will be implemented after developing additional batch scenario for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants