Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

There is no check of existance generator and exception when privileges are granted [CORE5852] #6112

Closed
firebird-issue-importer opened this issue Jun 20, 2018 · 5 comments

Comments

@firebird-issue-importer

Submitted by: @romansimakov

RDB$TRIGGER9 checks that object exists. After adding USAGE privilege on generator and exception related checks were not added to RDB$TRIGGER9. As result we can grant privilege to non existing object. In the same time it's reaaly hard to maintain system triggers in clean BLR code and after protecting system tables from modifications we may move such checks to engine.

Commits: a01d81d 364e29a

@firebird-issue-importer
Copy link
Author

firebird-issue-importer commented Jun 20, 2018

Modified by: @romansimakov

assignee: Roman Simakov [ roman-simakov ]

@firebird-issue-importer
Copy link
Author

firebird-issue-importer commented Jun 22, 2018

Commented by: @romansimakov

I used the follow script to test:

set echo on;
create database '/tmp/1.fdb';

grant select on table t to user u;

create table t(i integer);
grant update(c) on table t to user u;

grant select on v to user u;
grant execute on procedure p to user u;
grant execute on function f to user u;
grant execute on package p to user u;
grant usage on exception e to user u;
grant usage on generator g to user u;
grant usage on sequence s to user u;

create view v(i) as select i from t;
grant select on table v to user u;

@firebird-issue-importer
Copy link
Author

firebird-issue-importer commented Jun 22, 2018

Modified by: @romansimakov

status: Open [ 1 ] => Resolved [ 5 ]

resolution: Fixed [ 1 ]

Fix Version: 4.0 Beta 1 [ 10750 ]

Fix Version: 3.0.4 [ 10863 ]

@firebird-issue-importer
Copy link
Author

firebird-issue-importer commented Jun 23, 2018

Modified by: @pavel-zotov

status: Resolved [ 5 ] => Resolved [ 5 ]

QA Status: No test => Done successfully

@firebird-issue-importer
Copy link
Author

firebird-issue-importer commented Jun 23, 2018

Modified by: @pavel-zotov

status: Resolved [ 5 ] => Closed [ 6 ]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment