Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow the use of management statements in PSQL blocks [CORE5887] #6145

Closed
firebird-issue-importer opened this issue Aug 9, 2018 · 6 comments
Closed

Comments

@firebird-issue-importer
Copy link

@firebird-issue-importer firebird-issue-importer commented Aug 9, 2018

Submitted by: @asfernandes

Current management (SET ... / ALTER SESSION) statements are valid only
as top-level statements (and hence in EXECUTE STATEMENT too), i.e.,
cannot be in EXECUTE BLOCK or stored routine.

This is a problem, as some of these statements are good to be executed
in ON CONNECT triggers.

I propose a simple way to allow them in PSQL.

There is no reason to create BLR codes for them.

DSQL can generate them as EXECUTE STATEMENT (blr_exec_sql).

They will be validated (dsqlPass) as others statements in prepare time,
and will be validated as now when executed.

Commits: 200720e 3909a7e

====== Test Details ======

Added check for all statements mentioned in "README.management_statements_psql.md " except: alter session reset.
Test for SET TRUSTED ROLE was implemented as separate file "core_5887-trusted_role.fbt"
Test for "ALTER SESSION RESET" was deferred.

Sent letter to dimitr, hvlad and alex, 09.03.2019 13:43.

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Aug 9, 2018

Modified by: @asfernandes

assignee: Adriano dos Santos Fernandes [ asfernandes ]

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Aug 10, 2018

Modified by: @asfernandes

status: Open [ 1 ] => Resolved [ 5 ]

resolution: Fixed [ 1 ]

Fix Version: 4.0 Beta 1 [ 10750 ]

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Aug 15, 2018

Modified by: @pavel-zotov

status: Resolved [ 5 ] => Resolved [ 5 ]

QA Status: No test => Deferred

Test Details: Have question about "Statement failed, SQLSTATE = 25000 / no transaction for request".
Sent letter to ASF, 15.08.2018 20:06, waiting for reply.

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Mar 9, 2019

Modified by: @pavel-zotov

status: Resolved [ 5 ] => Resolved [ 5 ]

QA Status: Deferred => Done with caveats

Test Details: Have question about "Statement failed, SQLSTATE = 25000 / no transaction for request".
Sent letter to ASF, 15.08.2018 20:06, waiting for reply.

=>

Added check for all statements mentioned in "README.management_statements_psql.md " except:
* alter session reset
* set trusted role.

Sent letter to dimitr, hvlad and alex, 09.03.2019 13:43.

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Mar 9, 2019

Modified by: @pavel-zotov

status: Resolved [ 5 ] => Closed [ 6 ]

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Mar 10, 2019

Modified by: @pavel-zotov

status: Closed [ 6 ] => Closed [ 6 ]

Test Details: Added check for all statements mentioned in "README.management_statements_psql.md " except:
* alter session reset
* set trusted role.

Sent letter to dimitr, hvlad and alex, 09.03.2019 13:43.

=>

Added check for all statements mentioned in "README.management_statements_psql.md " except: alter session reset.
Test for SET TRUSTED ROLE was implemented as separate file "core_5887-trusted_role.fbt"
Test for "ALTER SESSION RESET" was deferred.

Sent letter to dimitr, hvlad and alex, 09.03.2019 13:43.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants