Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance dynamic libraries loading related error messages [CORE5908] #6166

Closed
firebird-issue-importer opened this issue Sep 7, 2018 · 6 comments
Closed

Comments

@firebird-issue-importer
Copy link

@firebird-issue-importer firebird-issue-importer commented Sep 7, 2018

Submitted by: @AlexPeshkoff

Due to wrong initial design of class ModuleLoader errors displayed when loading library fails miss OS-specific information about a reason of a failure (no such file, invalid format, unresolved external reference, etc.), they only say - module/library not loaded. This makes fixing related bugs extremely problematic in many cases.

Errors reported should be extended in order to show exact reason of a failure.

Commits: 6a63c3b 2d973b9

====== Test Details ======

Thanks to Alex for suggestion about implementation.

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Sep 7, 2018

Modified by: @AlexPeshkoff

assignee: Alexander Peshkov [ alexpeshkoff ]

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Sep 7, 2018

Commented by: @AlexPeshkoff

Messages are enhanced except deprecated UDFs and unfortunately ICU - in case of failure ICU is attempted to be loaded >50 times and reporting all errors to user is definitely unreal.

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Sep 7, 2018

Modified by: @AlexPeshkoff

status: Open [ 1 ] => Resolved [ 5 ]

resolution: Fixed [ 1 ]

Fix Version: 4.0 Beta 1 [ 10750 ]

Fix Version: 3.0.4 [ 10863 ]

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Sep 20, 2018

Modified by: @pavel-zotov

status: Resolved [ 5 ] => Resolved [ 5 ]

QA Status: No test => Cannot be tested

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Sep 20, 2018

Modified by: @pavel-zotov

status: Resolved [ 5 ] => Closed [ 6 ]

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Sep 20, 2018

Modified by: @pavel-zotov

status: Closed [ 6 ] => Closed [ 6 ]

QA Status: Cannot be tested => Done successfully

Test Details: Thanks to Alex for suggestion about implementation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment