Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trace could not work correctly with quoted file names in trace configurations [CORE5991] #6241

Closed
firebird-issue-importer opened this issue Jan 24, 2019 · 4 comments

Comments

@firebird-issue-importer

Submitted by: @hvlad

Trace configuration allows to specify file names in two places:
a) at "database" section header as file name pattern
b) at "log_filename" parameter, used to specify file name for audit log

Double quotes works as expected, the issue is about single quoted values.

When trace session with such configuration is active and user attached to some database,
the following happens:

In the case (a) error is reported:

Error creating trace session for database "DBNAME":
error while parsing trace configuration
line 15: error while compiling regular expression "'PATTERN'"

where DBNAME is the database name from connection string and 'PATTERN' is database pattern from trace configuration.
Error is reported via trace log (in case of user trace session) or firebird.log (in case of audit trace session).

In the case (b) the audit log file is not created and error is not logged (it will be adressed in separate ticket).

Commits: 15e6315 c6e0b9c

====== Test Details ======

Name of log for audit can not be tested: FB instance must be restarted in this case.
Checked issues related only to name of database file.

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Jan 24, 2019

Modified by: @hvlad

assignee: Vlad Khorsun [ hvlad ]

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Jan 28, 2019

Modified by: @hvlad

status: Open [ 1 ] => Resolved [ 5 ]

resolution: Fixed [ 1 ]

Fix Version: 4.0 Beta 1 [ 10750 ]

Fix Version: 3.0.5 [ 10885 ]

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Feb 27, 2019

Modified by: @pavel-zotov

status: Resolved [ 5 ] => Resolved [ 5 ]

QA Status: No test => Done with caveats

Test Details: Name of log for audit can not be tested: FB instance must be restarted in this case.
Checked issues related only to name of database file.

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Feb 27, 2019

Modified by: @pavel-zotov

status: Resolved [ 5 ] => Closed [ 6 ]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment