Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Building with --with-builtin-tommath doesn't work [CORE6061] #6311

Closed
firebird-issue-importer opened this issue May 9, 2019 · 4 comments
Closed

Comments

@firebird-issue-importer
Copy link

@firebird-issue-importer firebird-issue-importer commented May 9, 2019

Submitted by: Vadim Zeitlin (vz)

Building d2116ea (T4_0_0_Beta1-106-gd2116ea145) with

./configure --with-builtin-tomcrypt --with-builtin-tommath --without-editline --disable-static

doesn't work because tomcrypt doesn't find tommath headers. A trivial fix would be

---------------------------------- >8 --------------------------------------
diff --git a/extern/libtomcrypt/makefile.shared b/extern/libtomcrypt/makefile.shared
index b4e7c43062..e34d0746e1 100644
--- a/extern/libtomcrypt/makefile.shared
+++ b/extern/libtomcrypt/makefile.shared
@@ -14,7 +14,7 @@
#⁠ make -f makefile.shared PREFIX=/opt/libtom install
#⁠

-CFLAGS += -DLTC_PTHREAD -DUSE_LTM -DLTM_DESC -pthread
+CFLAGS += -DLTC_PTHREAD -DUSE_LTM -DLTM_DESC -pthread -I../libtommath

PLATFORM := $(shell uname | sed -e 's/_.*//')

---------------------------------- >8 --------------------------------------

but this almost surely shouldn't be done unconditionally.

Commits: a021ed4

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented May 13, 2019

Modified by: @AlexPeshkoff

assignee: Alexander Peshkov [ alexpeshkoff ]

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Jun 14, 2019

Modified by: @AlexPeshkoff

status: Open [ 1 ] => Resolved [ 5 ]

resolution: Fixed [ 1 ]

Fix Version: 4.0 Beta 2 [ 10888 ]

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Jun 16, 2019

Modified by: @pavel-zotov

status: Resolved [ 5 ] => Resolved [ 5 ]

QA Status: No test => Cannot be tested

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Jun 16, 2019

Modified by: @pavel-zotov

status: Resolved [ 5 ] => Closed [ 6 ]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants