Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Connection does not see itself in the MON$ATTACHMENTS when Domain/Username (using SSPI) is 31 bytes long [CORE6097] #6346

Closed
firebird-issue-importer opened this issue Jul 10, 2019 · 16 comments

Comments

@firebird-issue-importer

Submitted by: Maxim Kuzmin (cybermax)

We using trusted auth (Mapped from Win_Sspi) and our users have a login in Russian.
When FIO is very long, connect is not estabilished (CORE5866).
When FIO have 13 symbols,connection to the database passes without problems, but "select * from mon$attachments" returns 0 rows.
An example of such a user: DOMN\КовалевскаяАА.

Commits: fe0ffef 7591e31

====== Test Details ======

See notes in .fbt file.

@firebird-issue-importer
Copy link
Author

firebird-issue-importer commented Jul 10, 2019

Commented by: Maxim Kuzmin (cybermax)

Add: In CORE5866 length FIO is 14 symbols and is more than 31 (14 * 2 + 5 = 33).
There - 13 symbols. 13 * 2 + 5 = 31 symbols. The problem is when the name is 31 characters long.

@firebird-issue-importer
Copy link
Author

firebird-issue-importer commented Jul 10, 2019

Modified by: @AlexPeshkoff

assignee: Alexander Peshkov [ alexpeshkoff ]

@firebird-issue-importer
Copy link
Author

firebird-issue-importer commented Jul 10, 2019

Commented by: @dyemanov

Monitoring truncates the stored user name to 31 bytes but no terminator byte is added when strncpy copied exactly 31 bytes. The fix should be one-liner.

@firebird-issue-importer
Copy link
Author

firebird-issue-importer commented Jul 10, 2019

Modified by: Sean Leyne (seanleyne)

summary: Connection does not see itself in the MON$ATTACHMENTS => Connection does not see itself in the MON$ATTACHMENTS when User/Connection Name is more than 13 unicode characters

@firebird-issue-importer
Copy link
Author

firebird-issue-importer commented Jul 10, 2019

Modified by: Sean Leyne (seanleyne)

summary: Connection does not see itself in the MON$ATTACHMENTS when User/Connection Name is more than 13 unicode characters => Connection does not see itself in the MON$ATTACHMENTS when Username is longer than 13 unicode characters (31 characters)

@firebird-issue-importer
Copy link
Author

firebird-issue-importer commented Jul 10, 2019

Modified by: @AlexPeshkoff

assignee: Alexander Peshkov [ alexpeshkoff ] => Dmitry Yemanov [ dimitr ]

@firebird-issue-importer
Copy link
Author

firebird-issue-importer commented Jul 12, 2019

Modified by: @dyemanov

Fix Version: 3.0.5 [ 10885 ]

@firebird-issue-importer
Copy link
Author

firebird-issue-importer commented Jul 12, 2019

Commented by: @dyemanov

It should be fixed now, please test the next snapshot build, once it's available.

@firebird-issue-importer
Copy link
Author

firebird-issue-importer commented Jul 15, 2019

Commented by: Maxim Kuzmin (cybermax)

Dmitry, in area http://web.firebirdsql.org/download/snapshot_builds/win/3.0/ last build #⁠33152 from 7 july.

@firebird-issue-importer
Copy link
Author

firebird-issue-importer commented Jul 15, 2019

Commented by: @dyemanov

It's available now.

@firebird-issue-importer
Copy link
Author

firebird-issue-importer commented Jul 17, 2019

Commented by: Maxim Kuzmin (cybermax)

Dmitry, in the snapshot a connection sees itself in the MON$ATTACHMENTS.

@firebird-issue-importer
Copy link
Author

firebird-issue-importer commented Jul 17, 2019

Modified by: @dyemanov

status: Open [ 1 ] => Resolved [ 5 ]

resolution: Fixed [ 1 ]

Fix Version: 4.0 Beta 2 [ 10888 ]

@firebird-issue-importer
Copy link
Author

firebird-issue-importer commented Jul 17, 2019

Modified by: @dyemanov

summary: Connection does not see itself in the MON$ATTACHMENTS when Username is longer than 13 unicode characters (31 characters) => Connection does not see itself in the MON$ATTACHMENTS when Domain/Username (using SSPI) is 31 bytes long

@firebird-issue-importer
Copy link
Author

firebird-issue-importer commented Jul 25, 2019

Modified by: @pavel-zotov

status: Resolved [ 5 ] => Resolved [ 5 ]

QA Status: No test => Deferred

Test Details: Could not reproduce on 3.0.4 (Windows). Sent letter to alex and dimitr, 25.07.2019 09:18. Waiting for reply.

@firebird-issue-importer
Copy link
Author

firebird-issue-importer commented Jul 25, 2019

Modified by: @pavel-zotov

status: Resolved [ 5 ] => Resolved [ 5 ]

QA Status: Deferred => Done with caveats

Test Details: Could not reproduce on 3.0.4 (Windows). Sent letter to alex and dimitr, 25.07.2019 09:18. Waiting for reply.

=>

See notes in .fbt file.

@firebird-issue-importer
Copy link
Author

firebird-issue-importer commented Jul 25, 2019

Modified by: @pavel-zotov

status: Resolved [ 5 ] => Closed [ 6 ]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants