Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Building bundled libtommath fails [CORE6189] #6434

Closed
firebird-issue-importer opened this issue Nov 15, 2019 · 5 comments
Closed

Building bundled libtommath fails [CORE6189] #6434

firebird-issue-importer opened this issue Nov 15, 2019 · 5 comments

Comments

@firebird-issue-importer

Submitted by: Vadim Zeitlin (vz)

TL;DR: please undo the apparently accidentally committed part of 78376b0 which seems to be a local debug check

Building fails when using --with-builtin-tommath configure option because gen/Makefile contains this line

$\(MAKE\) \-C $\(ROOT\)/extern/libtommath \-f makefile\.shared LIBTOOL=$\(LIBTOOL\)

while extern/libtommath/makefile.shared contains this

 ifndef LIBTOOL
 LIBTOOL=libtool
 endif

So LIBTOOL ends up being defined, but empty, meaning that all attempts to use it fail.

The problematic line in gen/Makefile comes from builds/posix/Makefile.in and was added to it by 78376b0 seemingly accidentally, as it doesn't bear any relationship to the commit message. AFAICS the first chunk of this commit should be just reverted, which would fix the problem. Alternatively, fix extern/libtommath/makefile.shared to use ifeq($(LIBTOOL),) instead of checking if it's defined.

Note that this commit is in 3.0 branch only, so it doesn't affect master/4.0.

Commits: 7834625

@firebird-issue-importer
Copy link
Author

firebird-issue-importer commented Feb 8, 2020

Modified by: @AlexPeshkoff

assignee: Alexander Peshkov [ alexpeshkoff ]

@firebird-issue-importer
Copy link
Author

firebird-issue-importer commented Feb 8, 2020

Commented by: @AlexPeshkoff

A bit strange that Debian needs this option. Use of system library is IMO preferred.

@firebird-issue-importer
Copy link
Author

firebird-issue-importer commented Feb 8, 2020

Modified by: @AlexPeshkoff

status: Open [ 1 ] => Resolved [ 5 ]

resolution: Fixed [ 1 ]

Fix Version: 3.0.6 [ 10889 ]

@firebird-issue-importer
Copy link
Author

firebird-issue-importer commented Feb 9, 2020

Modified by: @pavel-zotov

status: Resolved [ 5 ] => Resolved [ 5 ]

QA Status: No test => Cannot be tested

@firebird-issue-importer
Copy link
Author

firebird-issue-importer commented Feb 9, 2020

Modified by: @pavel-zotov

status: Resolved [ 5 ] => Closed [ 6 ]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants