Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SHOW DOMAIN/TABLE does not display character set of system objects [CORE6262] #6504

Closed
firebird-issue-importer opened this issue Mar 11, 2020 · 3 comments

Comments

@firebird-issue-importer

Submitted by: @asfernandes

With CORE5064 (7b9b408) the engine started to write in RDB$FIELD_SUB_TYPE of CHAR/VARCHAR the set of constants (fb_text_subtype_text, fb_text_subtype_binary).

But earlier system fields were created with RDB$FIELD_SUB_TYPE with another set (dsc_text_type_none, dsc_text_type_fixed, dsc_text_type_ascii, dsc_text_type_metadata).

That make ISQL does not show the character set of system objects.

I'm fixing this with the assumption that fb_text_subtype_binary == dsc_text_type_fixed and that they mean the same thing, but maybe implementation of CORE5064 should be reviewed.

Commits: ec478b8

====== Test Details ======

Following domains have been excluded from check because they have rdb$charset_id = 0. SHOW DOMAIN statement will not show any charset for them:

RDB$CONSTRAINT_TYPE CHAR(11) Nullable
RDB$CONTEXT_VAR_NAME VARCHAR(80) Nullable
RDB$CONTEXT_VAR_VALUE VARCHAR(32765) Nullable
RDB$DEFERRABLE CHAR(3) Nullable
RDB$EDIT_STRING VARCHAR(127) Nullable
RDB$EXTERNAL_NAME CHAR(255) Nullable
RDB$FILE_NAME VARCHAR(255) Nullable
RDB$GUID CHAR(38) Nullable
RDB$MATCH_OPTION CHAR(7) Nullable
RDB$MESSAGE VARCHAR(1023) Nullable
RDB$PRIVILEGE CHAR(6) Nullable
RDB$RULE CHAR(11) Nullable

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Mar 11, 2020

Modified by: @asfernandes

status: Open [ 1 ] => Resolved [ 5 ]

resolution: Fixed [ 1 ]

Fix Version: 4.0 Beta 2 [ 10888 ]

assignee: Adriano dos Santos Fernandes [ asfernandes ]

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Mar 12, 2020

Modified by: @pavel-zotov

status: Resolved [ 5 ] => Resolved [ 5 ]

QA Status: No test => Done with caveats

Test Details: Following domains have been excluded from check because they have rdb$charset_id = 0. SHOW DOMAIN statement will not show any charset for them:

RDB$CONSTRAINT_TYPE CHAR(11) Nullable
RDB$CONTEXT_VAR_NAME VARCHAR(80) Nullable
RDB$CONTEXT_VAR_VALUE VARCHAR(32765) Nullable
RDB$DEFERRABLE CHAR(3) Nullable
RDB$EDIT_STRING VARCHAR(127) Nullable
RDB$EXTERNAL_NAME CHAR(255) Nullable
RDB$FILE_NAME VARCHAR(255) Nullable
RDB$GUID CHAR(38) Nullable
RDB$MATCH_OPTION CHAR(7) Nullable
RDB$MESSAGE VARCHAR(1023) Nullable
RDB$PRIVILEGE CHAR(6) Nullable
RDB$RULE CHAR(11) Nullable

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Mar 12, 2020

Modified by: @pavel-zotov

status: Resolved [ 5 ] => Closed [ 6 ]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants