Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase parse speed of long queries [CORE6274] #6516

Closed
firebird-issue-importer opened this issue Apr 3, 2020 · 7 comments
Closed

Increase parse speed of long queries [CORE6274] #6516

firebird-issue-importer opened this issue Apr 3, 2020 · 7 comments

Comments

@firebird-issue-importer
Copy link

@firebird-issue-importer firebird-issue-importer commented Apr 3, 2020

Submitted by: @asfernandes

With CORE6246 tests, for example, parse is very slow because parser keeps adding stack space in 16 increments, which makes lots of realloc and copies.

In a test (slow vm and debug build), changing YYSTACKGROWTH to 128 improves the test from 33s to 7s.

Commits: 4600136 c7de40c

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Apr 3, 2020

Modified by: @asfernandes

assignee: Adriano dos Santos Fernandes [ asfernandes ]

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Apr 3, 2020

Commented by: @AlexPeshkoff

Would not exponential growth (like in our string and Array) be even better? It was chosen exactly for the same reason as you describe above.

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Apr 3, 2020

Commented by: @asfernandes

Yes, I believe, but for now I preferred a very simple fix with a good balance between simplicity and improvement.

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Apr 3, 2020

Modified by: @asfernandes

status: Open [ 1 ] => Resolved [ 5 ]

resolution: Fixed [ 1 ]

Fix Version: 4.0 Beta 2 [ 10888 ]

Fix Version: 3.0.6 [ 10889 ]

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Apr 4, 2020

Modified by: @pavel-zotov

status: Resolved [ 5 ] => Resolved [ 5 ]

QA Status: No test => Cannot be tested

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Apr 4, 2020

Modified by: @pavel-zotov

status: Resolved [ 5 ] => Closed [ 6 ]

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Apr 5, 2020

Commented by: @asfernandes

I did a more real world test with release build in better machine: 13,9s to 0,25s.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants