Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.
Already on GitHub?
to your account
Submitted by: @asfernandes
With CORE6246 tests, for example, parse is very slow because parser keeps adding stack space in 16 increments, which makes lots of realloc and copies.
In a test (slow vm and debug build), changing YYSTACKGROWTH to 128 improves the test from 33s to 7s.
Commits: 4600136 c7de40c
The text was updated successfully, but these errors were encountered:
assignee: Adriano dos Santos Fernandes [ asfernandes ]
Sorry, something went wrong.
Commented by: @AlexPeshkoff
Would not exponential growth (like in our string and Array) be even better? It was chosen exactly for the same reason as you describe above.
Commented by: @asfernandes
Yes, I believe, but for now I preferred a very simple fix with a good balance between simplicity and improvement.
status: Open [ 1 ] => Resolved [ 5 ]
resolution: Fixed [ 1 ]
Fix Version: 4.0 Beta 2 [ 10888 ]
Fix Version: 3.0.6 [ 10889 ]
status: Resolved [ 5 ] => Resolved [ 5 ]
QA Status: No test => Cannot be tested
status: Resolved [ 5 ] => Closed [ 6 ]
I did a more real world test with release build in better machine: 13,9s to 0,25s.
No branches or pull requests