Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android port build failure [CORE6305] #6547

Closed
firebird-issue-importer opened this issue May 15, 2020 · 5 comments
Closed

Android port build failure [CORE6305] #6547

firebird-issue-importer opened this issue May 15, 2020 · 5 comments

Comments

@firebird-issue-importer

Submitted by: @AlexPeshkoff

After fb4beta1 two C++ libraries (ttmath & RE2) were added to firebird code base. Building them with NDK used earlier fails for a number of reasons, specially problematic is use of STL.

Commits: 30784c1

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented May 15, 2020

Modified by: @AlexPeshkoff

assignee: Alexander Peshkov [ alexpeshkoff ]

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented May 15, 2020

Commented by: @AlexPeshkoff

Obvious solution is NDK upgrade. That was done - but caused a need to tune flags needed for a build (difference with linux became much smaller). Also added build of static RE2 library for android.

As a side effect of changed NDK required minimum version of Android has grown - we need at least Android 7 now. Such big growth took place due to a bug in previous API versions that made standard C-library functions fgetpos/fsetpos be reported as missing at compile time with obvious compilation error.

Beta2 packages for android were built with applied fix for this issue using NDK21b.

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented May 15, 2020

Modified by: @AlexPeshkoff

status: Open [ 1 ] => Resolved [ 5 ]

resolution: Fixed [ 1 ]

Fix Version: 4.0 RC 1 [ 10930 ]

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented May 17, 2020

Modified by: @pavel-zotov

status: Resolved [ 5 ] => Resolved [ 5 ]

QA Status: No test => Cannot be tested

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented May 17, 2020

Modified by: @pavel-zotov

status: Resolved [ 5 ] => Closed [ 6 ]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants