Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NTILE/RANK/PERCENT_RANK may cause problems in big statements [CORE6325] #6566

Closed
firebird-issue-importer opened this issue Jun 8, 2020 · 5 comments

Comments

@firebird-issue-importer
Copy link

@firebird-issue-importer firebird-issue-importer commented Jun 8, 2020

Submitted by: @asfernandes

I do not have a test case, but NTILE/RANK/PERCENT_RANK is using USHORT for its impure offset, which may cause it to overflow and use the space of another statement or expression.

That may cause wrong value or even crashes.

Commits: 191296c cdd35c1

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Jun 8, 2020

Modified by: @asfernandes

status: Open [ 1 ] => Resolved [ 5 ]

resolution: Fixed [ 1 ]

Fix Version: 4.0 RC 1 [ 10930 ]

assignee: Adriano dos Santos Fernandes [ asfernandes ]

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Jun 9, 2020

Modified by: @pavel-zotov

status: Resolved [ 5 ] => Resolved [ 5 ]

QA Status: No test => Not enough information

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Jun 9, 2020

Modified by: @pavel-zotov

status: Resolved [ 5 ] => Resolved [ 5 ]

QA Status: Not enough information => Cannot be tested

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Jun 9, 2020

Modified by: @pavel-zotov

status: Resolved [ 5 ] => Closed [ 6 ]

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Jun 22, 2020

Modified by: @asfernandes

description: I do not have a test case, but NTILE is using USHORT for its impure offset, which may cause it to overflow and use the space of another statement or expression.

That may cause wrong value or even crashes.

=>

I do not have a test case, but NTILE/RANK/PERCENT_RANK is using USHORT for its impure offset, which may cause it to overflow and use the space of another statement or expression.

That may cause wrong value or even crashes.

summary: NTILE may cause problems in big statements => NTILE/RANK/PERCENT_RANK may cause problems in big statements

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants