Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong line and column information after IF statement [CORE6385] #6624

Closed
firebird-automations opened this issue Aug 10, 2020 · 5 comments
Closed

Comments

@firebird-automations
Copy link
Collaborator

Submitted by: @asfernandes

------
execute block
as
declare n integer;
begin
if (1 = 1) then
n = 1;
n = n / 0;
end!

Statement failed, SQLSTATE = 22012
arithmetic exception, numeric overflow, or string truncation
-Integer divide by zero. The code attempted to divide an integer value by an integer divisor of zero.
-At block line: 5, col: 5
------

The correct (line, column) of the error should be (7, 5).

I've tracked this as a regression introduced with CORE5183 fix but the actual problem is the way we used to get positions when backtrack happens.

Commits: dfcb0ba 1d70384

@firebird-automations
Copy link
Collaborator Author

Modified by: @asfernandes

assignee: Adriano dos Santos Fernandes [ asfernandes ]

@firebird-automations
Copy link
Collaborator Author

Modified by: @asfernandes

status: Open [ 1 ] => Resolved [ 5 ]

resolution: Fixed [ 1 ]

Fix Version: 4.0 RC 1 [ 10930 ]

@firebird-automations
Copy link
Collaborator Author

Modified by: @pavel-zotov

status: Resolved [ 5 ] => Resolved [ 5 ]

QA Status: No test => Done successfully

@firebird-automations
Copy link
Collaborator Author

Modified by: @pavel-zotov

status: Resolved [ 5 ] => Closed [ 6 ]

@firebird-automations
Copy link
Collaborator Author

Modified by: @asfernandes

Fix Version: 3.0.8 [ 10960 ]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment