Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove PIDFile/-pidfile directive/option from firebird Super(Server/Classic) systemd unit [CORE6413] #6651

Closed
firebird-issue-importer opened this issue Oct 8, 2020 · 4 comments

Comments

@firebird-issue-importer
Copy link

@firebird-issue-importer firebird-issue-importer commented Oct 8, 2020

Submitted by: Basil A. Sidorov (basid)

If forking/simple systemd service unit uses PIDFile directive, that file should contain pid of main control process from ExecStart directive.
For Firebird SuperServer/SuperClassic - fbguard, but pid-file contain pid of child process (firebird).
That prevent systemd from normal stop/restart FB service if fbguard restarted child firebird process.
As long as PIDFile directive are optional for systemd and -pidfile option are unneeded for fbguard - they should removed from unit.

Current unit (part):
Type=forking
PIDFile=/var/run/firebird/default.pid
ExecStart=${fb_install_prefix}/bin/fbguard -pidfile /var/run/firebird/default.pid -daemon -forever
StandardError=syslog

Suggest or:
Type=forking
ExecStart=${fb_install_prefix}/bin/fbguard -daemon -forever
StandardError=syslog

or:
Type=simple
ExecStart=${fb_install_prefix}/bin/fbguard -forever
StandardError=syslog

Commits: 0f65092 5e2ee2e

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Oct 8, 2020

Modified by: @AlexPeshkoff

assignee: Alexander Peshkov [ alexpeshkoff ]

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Oct 9, 2020

Modified by: @AlexPeshkoff

status: Open [ 1 ] => Resolved [ 5 ]

resolution: Fixed [ 1 ]

Fix Version: 4.0 RC 1 [ 10930 ]

Fix Version: 3.0.7 [ 10940 ]

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Oct 10, 2020

Modified by: @pavel-zotov

status: Resolved [ 5 ] => Resolved [ 5 ]

QA Status: No test => Cannot be tested

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Oct 10, 2020

Modified by: @pavel-zotov

status: Resolved [ 5 ] => Closed [ 6 ]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants