Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gfix cannot set big value for buffers [CORE6437] #6672

Closed
firebird-issue-importer opened this issue Nov 4, 2020 · 6 comments
Closed

gfix cannot set big value for buffers [CORE6437] #6672

firebird-issue-importer opened this issue Nov 4, 2020 · 6 comments

Comments

@firebird-issue-importer
Copy link

@firebird-issue-importer firebird-issue-importer commented Nov 4, 2020

Submitted by: @romansimakov

roman@roman-home % ./isql firebird/gen/Debug/firebird/bin
Use CONNECT or CREATE DATABASE to specify a database
SQL> create database '/tmp/buffb.fdb';
SQL> ^D% roman@roman-home % roman@roman-home % ./gfix -buffers 1000000 /tmp/buffb.fdb firebird/gen/Debug/firebird/bin
I/O error during "read" operation for file "/tmp/buffb.fdb"
-Error while trying to read from file
-Bad address

Firebird 3.0 works correctly

Commits: 8491f42 9bb7211

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Nov 4, 2020

Modified by: @hvlad

assignee: Vlad Khorsun [ hvlad ]

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Nov 4, 2020

Modified by: @romansimakov

summary: gfix cannot set buffers over 64000 => gfix cannot set big value for buffers

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Nov 5, 2020

Commented by: @hvlad

Firebird 3.0 is not affected, while bug (integer overflow) is present in its code as well.

Bug became visible due to security related changes in Firebird 4, see

Revision: dbc73bf
Author: AlexPeshkoff <mailto:peshkoff@mail.ru>
Date: 30.12.2016 18:17:58
Message:
Restored security checks related to CHANGE_HEADER_SETTINGS privilege during attachment initialization

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Nov 5, 2020

Modified by: @hvlad

status: Open [ 1 ] => Resolved [ 5 ]

resolution: Fixed [ 1 ]

Fix Version: 4.0 RC 1 [ 10930 ]

Fix Version: 3.0.8 [ 10960 ]

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Nov 9, 2020

Modified by: @pavel-zotov

status: Resolved [ 5 ] => Resolved [ 5 ]

QA Status: No test => Done successfully

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Nov 9, 2020

Modified by: @pavel-zotov

status: Resolved [ 5 ] => Closed [ 6 ]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants