Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

COMMENT ON USER can only apply comment on user defined by the default usermanager plugin [CORE6479] #6710

Closed
firebird-issue-importer opened this issue Jan 31, 2021 · 7 comments

Comments

@firebird-issue-importer

Submitted by: @mrotteveel

The COMMENT ON USER statement can only put comments on users of the default usermanager. The syntax should be extended to include an optional USING PLUGIN <pluginname> clause. For example `COMMENT ON USER x USING PLUGIN pluginname IS 'comment'`

With setting UserManager = Srp,Legacy_UserManager.

create user test1 password 'test1' using plugin srp;
create user test2 password 'test2' using plugin legacy_usermanager;

commit;

The following will succeed:

comment on user test1 is 'comment on user test1';

The following will fail:

comment on user test2 is `comment on user test2';

[336723990] [HY000]: Resource Exception. record not found for user: TEST2

Commits: 8dfaf3a f9b7cd5

====== Test Details ======

There is no sense to check for Legacy_UserManarer: comment for user will not be stored in the sec$users for this plugin.
Test verifies only Srp.

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Jan 31, 2021

Commented by: @aafemt

Wouldn't it be better to identify a user as <pluginname>.<username>? And not only here but in the rest of user-related places too.

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Jan 31, 2021

Commented by: @mrotteveel

Doing that would not be consistent with the USING PLUGIN <pluginname> as utilized in the user management statements. I'd prefer sticking to one syntax form, instead of introducing yet another form of syntax; such inconsistency is confusing.

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Jan 31, 2021

Modified by: @AlexPeshkoff

assignee: Alexander Peshkov [ alexpeshkoff ]

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Mar 11, 2021

Modified by: @AlexPeshkoff

status: Open [ 1 ] => Resolved [ 5 ]

resolution: Fixed [ 1 ]

Fix Version: 4.0.0 [ 10931 ]

Fix Version: 3.0.8 [ 10960 ]

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Mar 12, 2021

Modified by: @pavel-zotov

status: Resolved [ 5 ] => Resolved [ 5 ]

QA Status: No test => Deferred

Test Details: Have an issue related to sec$users data for Legacy* user. Sent letter to Alex, 12.03.2021 08:18.
Waiting for reply.

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Mar 12, 2021

Modified by: @pavel-zotov

status: Resolved [ 5 ] => Resolved [ 5 ]

QA Status: Deferred => Done with caveats

Test Details: Have an issue related to sec$users data for Legacy* user. Sent letter to Alex, 12.03.2021 08:18.
Waiting for reply.

=>

There is no sense to check for Legacy_UserManarer: comment for user will not be stored in the sec$users for this plugin.
Test verifies only Srp.

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Mar 12, 2021

Modified by: @pavel-zotov

status: Resolved [ 5 ] => Closed [ 6 ]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants