Do not allow the AST thread to release EX lock on a relation while it's in the deleting state #7252
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…'s in the deleting state The problem is rarely reproduced by bugs.core_2879 test. Without the fix the phase 4 of delete_relation DFW may fail because MET_lookup_relation_id cannot find a relation.
Contributor
Author
|
I also have a question about jrd_rel::rel_drop_mutex. Looks like it does not make sense anymore since relation vector was moved from dbb to att. Did I miss something? |
dyemanov
approved these changes
Aug 12, 2022
Contributor
Author
|
Should I prepare the PR for FB3? |
Member
Implementation of the shared metadata cache is in progress, so the mutex could become useful again. |
Member
Not necessary, I'll cherry-pick your commit to another branches myself. |
Contributor
Author
OK, it would be good. |
dyemanov
pushed a commit
that referenced
this pull request
Aug 15, 2022
…'s in the deleting state (#7252) The problem is rarely reproduced by bugs.core_2879 test. Without the fix the phase 4 of delete_relation DFW may fail because MET_lookup_relation_id cannot find a relation.
dyemanov
pushed a commit
that referenced
this pull request
Aug 15, 2022
…'s in the deleting state (#7252) The problem is rarely reproduced by bugs.core_2879 test. Without the fix the phase 4 of delete_relation DFW may fail because MET_lookup_relation_id cannot find a relation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem is rarely reproduced by bugs.core_2879 test. Without the fix the phase 4 of delete_relation DFW may fail because MET_lookup_relation_id cannot find a relation.