Re-add indexes for object name without schema name, removing their uniqueness #8664
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
I suggest to defer this PR until we resolve the known performance regressions in the existing code. Otherwise, new indices may hide these issues (allowing better plans than now), but strike back later when the new "backward compatibility" indices are removed. |
Member
Author
|
Do we still have these performance problems? |
Member
AFAIK no, but I will double-check the old cases and report back. |
Member
|
I've double-checked all regression cases reported by Pavel after schemas were merged and found that all of them are currently fixed. We seem to still have performance issues, as reported here, but I don't think they're related to system query plans and should be researched separately. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.