Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add basic java.time support for setObject() to Jaybird 2.2 [JDBC339] #165

Closed
firebird-issue-importer opened this issue Feb 13, 2014 · 9 comments

Comments

@firebird-issue-importer

Submitted by: @mrotteveel

Jira_subtask_inward JDBC338

Add basic java.time support for setObject() to Jaybird 2.2.

The current implementation is missing some existing required conversions (notably ResultSet.getObject(int/String, Class<?>)), so we leave that out for now (should be tackled in the parent issue for Jaybird 3.0 or a later Jaybird 2.2.x)

Commits: 6a84ea3 0f3394c bedb624 e6929aa FirebirdSQL/fbt-repository@ad03477 FirebirdSQL/fbt-repository@0fe7edd FirebirdSQL/fbt-repository@933f3c6 FirebirdSQL/fbt-repository@06fa710

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Feb 13, 2014

Modified by: @mrotteveel

Fix Version: Jaybird 2.2.5 [ 10582 ]

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Feb 13, 2014

Modified by: @mrotteveel

status: Open [ 1 ] => In Progress [ 3 ]

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Feb 14, 2014

Commented by: @mrotteveel

Implementation added to Jaybird 2.2.5. Skeleton implementation without actual JDBC 4.2 added to Jaybird 3.0. JDBC 4.2 support will be frontported to Jaybird 3.0 once the new wire protocol is in place.

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Feb 14, 2014

Modified by: @mrotteveel

status: In Progress [ 3 ] => Resolved [ 5 ]

resolution: Fixed [ 1 ]

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Mar 27, 2014

Commented by: @mrotteveel

Current conversion for java.time types might not be optimal. The current conversion is from java.time.LocalDateTime to java.sql.Timestamp, from java.time.LocalDate to java.sql.Date and from java.time.LocalTime to java.sql.Time before storing in the database. It might be better to do the conversion directly, as this avoids potential interference of the current JVM timezone when interpreting time, and truncation of subsecond values.

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Mar 27, 2014

Modified by: @mrotteveel

status: Resolved [ 5 ] => Reopened [ 4 ]

resolution: Fixed [ 1 ] =>

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Mar 30, 2014

Commented by: @mrotteveel

Added direct implementation in Java 8 + increased java.sql.Timestamp precision from 1 millisecond to 100 microseconds (Firebird maximum precision).

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Mar 30, 2014

Modified by: @mrotteveel

status: Reopened [ 4 ] => Resolved [ 5 ]

resolution: Fixed [ 1 ]

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Apr 27, 2014

Modified by: @mrotteveel

status: Resolved [ 5 ] => Closed [ 6 ]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment