Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not all Java ChatSet names/aliases are available [JDBC267] #314

Closed
firebird-issue-importer opened this issue Aug 12, 2012 · 7 comments
Closed

Comments

@firebird-issue-importer

Submitted by: fabianobonin (fabianobonin)

Relate to JDBC268

System.out.println(Charset.defaultCharset().name());
output: windows-1252

We have two problems here:

1) If i pass the value "windows-1252" to Jaybird in the "charSet" property, it
throws an exception during connection, because it doesn´t know this charset name. It expects "cp1252" instead.

2) When i pass a unknown charset name to Jaybird, it throws a RuntimeError,
instead of a SQLException error, what makes it "uncatcheable" in most cases,
unless the code is catching RuntimeException's, what is not usual.

About problem 1, according to Mark (http://tech.groups.yahoo.com/group/Firebird-Java/message/10752), Jaybird took Java charset names from Java 1.3, but there was a change in Java 1.4, wich changed some charset names and/or aliases. So it would be nice to have the new names/aliases mapped.

Fabiano

Commits: ac20951 36f66f5

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Aug 18, 2012

Commented by: @mrotteveel

Scheduled for 2.3, if it is easy to do I will also include it in 2.2.1

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Aug 18, 2012

Modified by: @mrotteveel

Version: Jaybird 2.2 [ 10053 ]

Version: Jaybird 2.1.6 [ 10285 ]

Fix Version: Jaybird 2.2.1 [ 10474 ]

Fix Version: Jaybird 2.3 [ 10440 ]

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Aug 19, 2012

Modified by: @mrotteveel

Link: This issue relate to JDBC268 [ JDBC268 ]

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Aug 19, 2012

Commented by: @mrotteveel

Commited change to trunk to address both this and JDBC268. I do think it needs a little bit more polish before it can go to Jaybird 2.2.1 as well.

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Aug 19, 2012

Modified by: @mrotteveel

assignee: Roman Rokytskyy [ rrokytskyy ] => Mark Rotteveel [ avalanche1979 ]

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Sep 2, 2012

Modified by: @mrotteveel

status: Open [ 1 ] => Resolved [ 5 ]

resolution: Fixed [ 1 ]

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Feb 21, 2013

Modified by: @mrotteveel

status: Resolved [ 5 ] => Closed [ 6 ]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants