Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Holdable ResultSet is closed on autocommit [JDBC305] #351

Closed
firebird-issue-importer opened this issue Mar 30, 2013 · 11 comments
Closed

Holdable ResultSet is closed on autocommit [JDBC305] #351

firebird-issue-importer opened this issue Mar 30, 2013 · 11 comments

Comments

@firebird-issue-importer

Submitted by: @mrotteveel

Is related to JDBC304
Is related to JDBC209
Relate to JDBC307

A holdable ResultSet is closed on commit (during autocommit), it should remain open. This is related to JDBC304 where in 2.2.x no rows can be retrieved from a holdable ResultSet after commit.

The logic surrounding statement completion, commits etc in the driver spreads responsibility around too much (eg the transaction coordinator needs to know what happens with statements, Statement needs to know what should happen with the ResultSet and vice versa). This may need to be reworked in an observer pattern to decouple this.

Commits: 68fa2d2 72ff1fd FirebirdSQL/fbt-repository@611977c FirebirdSQL/fbt-repository@005e6c5

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Mar 30, 2013

Commented by: @mrotteveel

Tentatively scheduled for 2.2.3, may need to defer some work to 2.3 as it is not a good idea to tear up the existing structure in a point release.

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Mar 30, 2013

Modified by: @mrotteveel

Fix Version: Jaybird 2.2.3 [ 10510 ]

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Mar 30, 2013

Modified by: @mrotteveel

Link: This issue is related to JDBC304 [ JDBC304 ]

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Mar 30, 2013

Modified by: @mrotteveel

Link: This issue is related to JDBC209 [ JDBC209 ]

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Mar 30, 2013

Modified by: @mrotteveel

description: A holdable ResultSet is closed on commit, it should remain open. This is related to JDBC304 where in 2.2.x no rows can be retrieved from a holdable ResultSet after commit.

The logic surrounding statement completion, commits etc in the driver spreads responsibility around too much (eg the transaction coordinator needs to know what happens with statements, Statement needs to know what should happen with the ResultSet and vice versa). This may need to be reworked in an observer pattern to decouple this.

=>

A holdable ResultSet is closed on commit (during autocommit), it should remain open. This is related to JDBC304 where in 2.2.x no rows can be retrieved from a holdable ResultSet after commit.

The logic surrounding statement completion, commits etc in the driver spreads responsibility around too much (eg the transaction coordinator needs to know what happens with statements, Statement needs to know what should happen with the ResultSet and vice versa). This may need to be reworked in an observer pattern to decouple this.

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Mar 30, 2013

Modified by: @mrotteveel

Link: This issue relate to JDBC307 [ JDBC307 ]

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Mar 30, 2013

Modified by: @mrotteveel

summary: Holdable ResultSet is closed on commit => Holdable ResultSet is closed on autocommit

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Mar 30, 2013

Commented by: @mrotteveel

Changes made for JDBC304 fix this problem. More radical changes will be done as part of JDBC307 for Jaybird 2.3

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Mar 30, 2013

Modified by: @mrotteveel

Fix Version: Jaybird 2.3 [ 10440 ]

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Mar 30, 2013

Modified by: @mrotteveel

status: Open [ 1 ] => Resolved [ 5 ]

resolution: Fixed [ 1 ]

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented May 11, 2013

Modified by: @mrotteveel

status: Resolved [ 5 ] => Closed [ 6 ]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment