Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FBConnectionProperties.setCharSet encoding issue [JDBC315] #361

Closed
firebird-issue-importer opened this issue Jul 13, 2013 · 4 comments
Closed

Comments

@firebird-issue-importer

Submitted by: @mrotteveel

While working on JDBC314, I noticed that the code did the following in FBConnectionProperties.setCharSet(...):

String encoding = getStringProperty(LOCAL_ENCODING_PROPERTY);
if (encoding != null)
return;

encoding = EncodingFactory.getIscEncoding(charSet);

if (encoding != null)
setStringProperty(ENCODING_PROPERTY, encoding);

Given what this code is supposed to do (set the Firebird encoding to match the java charSet if the Firebird encoding wasn't already set, see also the reverse code in setEncoding(...)), the first statement should be:
String encoding = getStringProperty(ENCODING_PROPERTY);

Commits: a3c3ef1 FirebirdSQL/fbt-repository@22d2722 FirebirdSQL/fbt-repository@a691022

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Jul 13, 2013

Commented by: @mrotteveel

Scheduled for 2.2.4 and 2.3. Solution for 2.3 will initially be committed to the wire protocol improvements branch as I am currently overhauling the character set / encoding implementation for Jaybird 2.3

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Jul 13, 2013

Modified by: @mrotteveel

Fix Version: Jaybird 2.2.4 [ 10531 ]

Fix Version: Jaybird 2.3 [ 10440 ]

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Jul 13, 2013

Modified by: @mrotteveel

status: Open [ 1 ] => Resolved [ 5 ]

resolution: Fixed [ 1 ]

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Dec 8, 2013

Modified by: @mrotteveel

status: Resolved [ 5 ] => Closed [ 6 ]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants