Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement BOOLEAN support [JDBC321] #367

Closed
firebird-issue-importer opened this issue Aug 2, 2013 · 8 comments
Closed

Implement BOOLEAN support [JDBC321] #367

firebird-issue-importer opened this issue Aug 2, 2013 · 8 comments

Comments

@firebird-issue-importer
Copy link

@firebird-issue-importer firebird-issue-importer commented Aug 2, 2013

Submitted by: @mrotteveel

Implement Firebird 3 BOOLEAN support, consider including support in 2.2.x as well.

Commits: aeafd43 1ec7ba4 d62b00d FirebirdSQL/fbt-repository@38b2479 FirebirdSQL/fbt-repository@27f361b FirebirdSQL/fbt-repository@0fd0185

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Aug 2, 2013

Modified by: @mrotteveel

description: Implement BOOLEAN support, consider including support in 2.2.x as well. => Implement Firebird 3 BOOLEAN support, consider including support in 2.2.x as well.

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Aug 10, 2013

Modified by: @mrotteveel

Fix Version: Jaybird 2.2.4 [ 10531 ]

Fix Version: Jaybird 2.3 [ 10440 ]

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Aug 10, 2013

Commented by: @mrotteveel

Implemented boolean support in Jaybird 2.2.

A boolean field can also be set with all numeric setters and the string setter (as implied by JDBC 4.1 appendix B).

For numeric types, currently only 0 will set to false and all other values will set to true. This is something that might change in the future. Only 0 for false and 1 for true are guaranteed, in the future we might decide to throw a conversion exception for other values!

For string types we currently set true for "true", "T", "Y" and "1" (case insensitive, ignoring whitespace), all other values will set false; this is for compatibility with the current getBoolean behaviour of FBStringField. This is something that might change in the future. Only "true" and "1" for true and "false" and "0" for false are guaranteed (case insensitive, ignoring whitespace), in the future we might decide to throw a conversion exception for other values!

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Aug 10, 2013

Commented by: @mrotteveel

Implementation hasn't been tested with native/embedded yet

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Oct 27, 2013

Commented by: @mrotteveel

Implementation also works with native Firebird 3 client library. Yet to test how it is handled with a Firebird 2.5 client library with Firebird 3.

As far as I can tell Firebird 3 embedded isn't included in builds, or the way it works has changed in Firebird 3.

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Nov 2, 2013

Commented by: @mrotteveel

No problems with boolean when using Firebird 2.5 client library to connect.

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Nov 24, 2013

Modified by: @mrotteveel

status: Open [ 1 ] => Resolved [ 5 ]

resolution: Fixed [ 1 ]

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Dec 8, 2013

Modified by: @mrotteveel

status: Resolved [ 5 ] => Closed [ 6 ]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants