Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jaybird should specify dialect 3 in dpb when no explicit dialect was set. [JDBC327] #373

Closed
firebird-issue-importer opened this issue Oct 26, 2013 · 7 comments

Comments

@firebird-issue-importer

Submitted by: @mrotteveel

When no explicit dialect is specified in the connection string or connection properties, then no dialect is sent in the DPB, this turns out to be wrong, because Firebird will default to dialect 1.

The impact of this is not very high: the only known effect is that (case sensitive) quoted rolenames do not work. Dialect 3 queries work as the dialect always needs to be passed when preparing statements and there Jaybird defaults to dialect 3 if no dialect is specified.

Commits: b387598 FirebirdSQL/fbt-repository@778fa96

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Oct 26, 2013

Commented by: @mrotteveel

To be fixed in Jaybird 2.2.4. The new wire protocol implementation in 2.3 already fixed this.

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Oct 26, 2013

Modified by: @mrotteveel

Fix Version: Jaybird 2.2.4 [ 10531 ]

Fix Version: Jaybird 2.3 [ 10440 ]

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Oct 26, 2013

Modified by: @mrotteveel

description: When no explicit dialect is specified in the connection string or connection properties, then no dialect is sent in the DPB, this turns out to be wrong, because Firebird will default to dialect 1.

The impact of this is not very high: the only known effect is that (case sensitive) quoted rolenames do not work, as the dialect always needs to be passed when preparing statements.

=>

When no explicit dialect is specified in the connection string or connection properties, then no dialect is sent in the DPB, this turns out to be wrong, because Firebird will default to dialect 1.

The impact of this is not very high: the only known effect is that (case sensitive) quoted rolenames do not work, as the dialect always needs to be passed when preparing statements and there Jaybird defaults to dialect 3 if no dialect is specified.

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Oct 26, 2013

Modified by: @mrotteveel

description: When no explicit dialect is specified in the connection string or connection properties, then no dialect is sent in the DPB, this turns out to be wrong, because Firebird will default to dialect 1.

The impact of this is not very high: the only known effect is that (case sensitive) quoted rolenames do not work, as the dialect always needs to be passed when preparing statements and there Jaybird defaults to dialect 3 if no dialect is specified.

=>

When no explicit dialect is specified in the connection string or connection properties, then no dialect is sent in the DPB, this turns out to be wrong, because Firebird will default to dialect 1.

The impact of this is not very high: the only known effect is that (case sensitive) quoted rolenames do not work. Dialect 3 queries work as the dialect always needs to be passed when preparing statements and there Jaybird defaults to dialect 3 if no dialect is specified.

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Oct 26, 2013

Commented by: @mrotteveel

Before attach/create a dpb item with dialect 3 is inserted if no dialect was set.

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Oct 26, 2013

Modified by: @mrotteveel

status: Open [ 1 ] => Resolved [ 5 ]

resolution: Fixed [ 1 ]

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Dec 8, 2013

Modified by: @mrotteveel

status: Resolved [ 5 ] => Closed [ 6 ]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment