Incorrect use of WeakHashMap in FBManagedConnectionFactory and FBDriver [JDBC364]

[firebird-issue-importer]

Submitted by: @mrotteveel

In JDBC249 I used a WeakHashMap for the mcfInstances in FBManagedConnectionFactory. This creates a memory leak as a strong reference is maintained to itself. Something similar happens in FBDriver. This needs to be fixed.

Commits: a37c40e 0dddd3d 9231722 fbcced3 FirebirdSQL/fbt-repository@6ef4f5a FirebirdSQL/fbt-repository@9abaccd FirebirdSQL/fbt-repository@e798fe1 FirebirdSQL/fbt-repository@db52633

[firebird-issue-importer]

Modified by: @mrotteveel

Fix Version: Jaybird 3.0 [ 10440 ]

[firebird-issue-importer]

Modified by: @mrotteveel

Fix Version: Jaybird 2.2.6 [ 10588 ]

[firebird-issue-importer]

Commented by: @mrotteveel

Replaced cache key with (clone) of connection properties, replaced WeakHashMap with a ConcurrentHashMap where the value is a SoftReference. Included cleanup routine to remove stale (null-ed) references from the map.

In general this will behave the same, but under memory pressure the cache will actually be cleaned.

[firebird-issue-importer]

Modified by: @mrotteveel

status: Open [ 1 ] => Resolved [ 5 ]

resolution: Fixed [ 1 ]

[firebird-issue-importer]

Modified by: @mrotteveel

status: Resolved [ 5 ] => Closed [ 6 ]