Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EncodingFactory doesn't handle UnsupportedCharsetException [JDBC371] #413

Closed
firebird-issue-importer opened this issue Nov 13, 2014 · 5 comments

Comments

@firebird-issue-importer

Submitted by: @mrotteveel

EncodingFactory in Jaybird 2.2 doesn't handle UnsupportedCharsetException (and IllegalCharsetNameException).

As reported in Firebird-java:

Hi Mark,

I get this exception when setting the character set as advised with Excelsion JET jvm.
Tried with both WIN1252 and ISO8859_1.

BR,
Hugo.

java.nio.charset.UnsupportedCharsetException: EUC_JP
at java.nio.charset.Charset.<unknown>(Unknown Source)
at org.firebirdsql.encodings.EncodingFactory.loadEncodings(Unknown Source)
at org.firebirdsql.encodings.EncodingFactory.getJavaEncoding(Unknown Source)
at org.firebirdsql.jdbc.FBDriverPropertyManager.<unknown>(Unknown Source)
at org.firebirdsql.jdbc.FBDriverPropertyManager.normalize(Unknown Source)
at org.firebirdsql.jdbc.AbstractDriver.connect(Unknown Source)

Commits: 649a0fc FirebirdSQL/fbt-repository@f189d96

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Nov 13, 2014

Commented by: @mrotteveel

The new EncodingSet in Jaybird 3 already handles this; only needs to be fixed in Jaybird 2.2.

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Nov 13, 2014

Modified by: @mrotteveel

Fix Version: Jaybird 2.2.6 [ 10588 ]

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Nov 18, 2014

Commented by: @mrotteveel

Now catching IllegalCharsetNameException and UnsupportedCharsetException, tested by misspelling the character set name in isc_encodings.properties

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Nov 18, 2014

Modified by: @mrotteveel

status: Open [ 1 ] => Resolved [ 5 ]

resolution: Fixed [ 1 ]

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Dec 30, 2014

Modified by: @mrotteveel

status: Resolved [ 5 ] => Closed [ 6 ]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment