Current method of quoting in FBRowUpdater incorrect for dialect 1 [JDBC372]

[firebird-issue-importer]

Submitted by: @mrotteveel

It looks like the current method of quoting object names in FBRowUpdater is wrong for dialect 1 databases. Test this and fix if necessary.

Commits: 007d903 6783787 FirebirdSQL/fbt-repository@151d677 FirebirdSQL/fbt-repository@e327f92

[firebird-issue-importer]

Modified by: @mrotteveel

Fix Version: Jaybird 2.2.6 [ 10588 ]

Fix Version: Jaybird 3.0 [ 10440 ]

[firebird-issue-importer]

Modified by: @mrotteveel

description: It looks like the current method of quoting object names in FBRowUpdater is wrong for dialect 1 database. Test this and fix if necessary. => It looks like the current method of quoting object names in FBRowUpdater is wrong for dialect 1 databases. Test this and fix if necessary.

[firebird-issue-importer]

Commented by: @mrotteveel

Added test. As expected insertRow(), updateRow() fail and deleteRow() doesn't delete due to quotes (which are not supported in dialect 1). deleteRow() with dialect1 might actually delete the entire table if the value of the primary is a string and is equal to its own name (as the quoted column name is interpreted as a string).

[firebird-issue-importer]

Commented by: @mrotteveel

Fixed in 2.2 and 3.0

[firebird-issue-importer]

Modified by: @mrotteveel

status: Open [ 1 ] => Resolved [ 5 ]

resolution: Fixed [ 1 ]

[firebird-issue-importer]

Modified by: @mrotteveel

status: Resolved [ 5 ] => Closed [ 6 ]