Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Current method of quoting in FBRowUpdater incorrect for dialect 1 [JDBC372] #414

Closed
firebird-issue-importer opened this issue Nov 15, 2014 · 6 comments

Comments

@firebird-issue-importer

Submitted by: @mrotteveel

It looks like the current method of quoting object names in FBRowUpdater is wrong for dialect 1 databases. Test this and fix if necessary.

Commits: 007d903 6783787 FirebirdSQL/fbt-repository@151d677 FirebirdSQL/fbt-repository@e327f92

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Nov 15, 2014

Modified by: @mrotteveel

Fix Version: Jaybird 2.2.6 [ 10588 ]

Fix Version: Jaybird 3.0 [ 10440 ]

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Nov 15, 2014

Modified by: @mrotteveel

description: It looks like the current method of quoting object names in FBRowUpdater is wrong for dialect 1 database. Test this and fix if necessary. => It looks like the current method of quoting object names in FBRowUpdater is wrong for dialect 1 databases. Test this and fix if necessary.

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Dec 2, 2014

Commented by: @mrotteveel

Added test. As expected insertRow(), updateRow() fail and deleteRow() doesn't delete due to quotes (which are not supported in dialect 1). deleteRow() with dialect1 might actually delete the entire table if the value of the primary is a string and is equal to its own name (as the quoted column name is interpreted as a string).

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Dec 13, 2014

Commented by: @mrotteveel

Fixed in 2.2 and 3.0

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Dec 13, 2014

Modified by: @mrotteveel

status: Open [ 1 ] => Resolved [ 5 ]

resolution: Fixed [ 1 ]

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Dec 30, 2014

Modified by: @mrotteveel

status: Resolved [ 5 ] => Closed [ 6 ]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment