Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DatabaseMetaData supportsGetGeneratedKeys reports true when antlr-runtime not available. [JDBC412] #453

Closed
firebird-issue-importer opened this issue Nov 3, 2015 · 4 comments

Comments

@firebird-issue-importer
Copy link

@firebird-issue-importer firebird-issue-importer commented Nov 3, 2015

Submitted by: @mrotteveel

DatabaseMetaData supportsGetGeneratedKeys reports true when antlr-runtime not available.

It should report false when not available to allow tools to correctly detect support.

Commits: c353c98 7ee2e05

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Nov 3, 2015

Modified by: @mrotteveel

Fix Version: Jaybird 2.2.10 [ 10723 ]

Fix Version: Jaybird 3.0 [ 10440 ]

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Jan 23, 2016

Commented by: @mrotteveel

DatabaseMetaData.supportsGetGeneratedKeys now reports true when the statement parser was loaded successfully (the antlr-runtime is on the classpath) and the Firebird version supports insert ... returning (that is: 2.0 or higher).

master: c353c98
Jaybird_2_2: 7ee2e05

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Jan 23, 2016

Modified by: @mrotteveel

status: Open [ 1 ] => Resolved [ 5 ]

resolution: Fixed [ 1 ]

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Mar 13, 2016

Modified by: @mrotteveel

status: Resolved [ 5 ] => Closed [ 6 ]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment