Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deny connection with no character set specified by default [JDBC446] #487

Closed
firebird-issue-importer opened this issue Jul 26, 2016 · 13 comments
Closed

Comments

@firebird-issue-importer

Submitted by: @mrotteveel

Replaces JDBC257
Is related to JDBC502

When a user did not specify a connection character set using lc_ctype/encoding or charSet, we should deny connection by default. If a user wants to use character set NONE as the connection character set, it will need to be specified explicitly.

For backwards compatibility, add a system property, org.firebirdsql.jdbc.defaultConnectionEncoding (with the Firebird character set name) that overrides this behavior.

Commits: 54c51be

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Jul 26, 2016

Modified by: @mrotteveel

Fix Version: Jaybird 3.0 [ 10440 ]

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Jul 26, 2016

Modified by: @mrotteveel

description: When a user did not specify a connection character set using lc_ctype/encoding or charSet, we should deny connection by default. If a user wants to use character set NONE as the connection character set, it will need to be specified explicitly.

For backwards compatibility, add a system property, org.firebirdsql.jdbc.defaultConnectionCharacterSet that overrides this behavior.

=>

When a user did not specify a connection character set using lc_ctype/encoding or charSet, we should deny connection by default. If a user wants to use character set NONE as the connection character set, it will need to be specified explicitly.

For backwards compatibility, add a system property, org.firebirdsql.jdbc.defaultConnectionEncoding (with the Firebird character set name) that overrides this behavior.

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Jul 26, 2016

Modified by: @mrotteveel

status: Open [ 1 ] => Resolved [ 5 ]

resolution: Fixed [ 1 ]

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Jul 30, 2016

Modified by: @mrotteveel

Link: This issue replaces JDBC257 [ JDBC257 ]

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Nov 22, 2016

Commented by: William L Thomson Jr (wltjr)

I am having lots of issues using this new feature. I cannot seem to pass the proper character set. I am doing this in tomcat, and have been using Jaybird with Commons DBCP. I have tried all sorts of things, even setting -Dorg.firebirdsql.jdbc.defaultConnectionEncoding globally, and adding charSet onto URLs. I either end up with the connection being denied. Other times nothing happens. Then other times I get bad username and/or password. I am working with existing, works just fine with 2.x. I am trying to set the character set but it does not seem to work anywhere I have tried. The release notes are VERY vague, mentioning several variables but not where they are set, order, which to use, etc.

I really do not understand why connections need to be denied rather than fall to old behavior. Why anything has to be set to revert to old. Which the old behavior even does not seem to work. I have not had any working combination yet, and have wasted an hour or so. I just ended up going back to 2.x.

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Nov 24, 2016

Modified by: @mrotteveel

status: Resolved [ 5 ] => Reopened [ 4 ]

resolution: Fixed [ 1 ] =>

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Nov 24, 2016

Commented by: @mrotteveel

William, I tried to send you an e-mail but it got bounced by your mailserver. Can you contact me at mark (at) lawinegevaar (dot) nl

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Jan 3, 2017

Commented by: @mrotteveel

I have closed this ticket again, if you are having problems with this change, then please create a new issue with all relevant details, or send an email to the Firebird-java mailinglist if you want to discuss this.

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Jan 3, 2017

Modified by: @mrotteveel

status: Reopened [ 4 ] => Closed [ 6 ]

resolution: Fixed [ 1 ]

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Jan 3, 2017

Modified by: @mrotteveel

status: Closed [ 6 ] => Reopened [ 4 ]

resolution: Fixed [ 1 ] =>

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Jan 3, 2017

Modified by: @mrotteveel

status: Reopened [ 4 ] => Resolved [ 5 ]

resolution: Fixed [ 1 ]

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented May 7, 2017

Modified by: @mrotteveel

status: Resolved [ 5 ] => Closed [ 6 ]

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Jun 25, 2017

Modified by: @mrotteveel

Link: This issue is related to JDBC502 [ JDBC502 ]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants