Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow absolute position with value 0 [JDBC453] #492

Closed
firebird-issue-importer opened this issue Sep 11, 2016 · 5 comments
Closed

Allow absolute position with value 0 [JDBC453] #492

firebird-issue-importer opened this issue Sep 11, 2016 · 5 comments

Comments

@firebird-issue-importer

Submitted by: @mrotteveel

Jaybird currently throws an exception when calling ResultSet.absolute(0). This should be changed to allow value 0. Between JDBC 2 (Java 1.3.1) and JDBC 3 (1.4.2) the javadoc of ResultSet.absolute was changed from

"Throws:
SQLException - if a database access error occurs, the row is 0, or the result set type is TYPE_FORWARD_ONLY"

to

"Throws:
SQLException - if a database access error occurs, or the result set type is TYPE_FORWARD_ONLY"

See also: http://stackoverflow.com/questions/39429401/jaybird-firebird-jdbc-absolute-method

Commits: d32747a

@firebird-issue-importer
Copy link
Author

Modified by: @mrotteveel

Fix Version: Jaybird 2.2.12 [ 10781 ]

Fix Version: Jaybird 3.0 [ 10440 ]

@firebird-issue-importer
Copy link
Author

Modified by: @mrotteveel

description: Jaybird currently throws an exception when calling ResultSet.absolute(0). This should be changed to allow value 0. Between JDBC 2 (Java 1.3.1) and JDBC 3 (1.4.2) the javadoc of ResultSet.absolute was changed from

"Throws:
SQLException - if a database access error occurs, the row is 0, or the result set type is TYPE_FORWARD_ONLY"

to

"Throws:
SQLException - if a database access error occurs, or the result set type is TYPE_FORWARD_ONLY"

=>

Jaybird currently throws an exception when calling ResultSet.absolute(0). This should be changed to allow value 0. Between JDBC 2 (Java 1.3.1) and JDBC 3 (1.4.2) the javadoc of ResultSet.absolute was changed from

"Throws:
SQLException - if a database access error occurs, the row is 0, or the result set type is TYPE_FORWARD_ONLY"

to

"Throws:
SQLException - if a database access error occurs, or the result set type is TYPE_FORWARD_ONLY"

See also: http://stackoverflow.com/questions/39429401/jaybird-firebird-jdbc-absolute-method

@firebird-issue-importer
Copy link
Author

Commented by: @mrotteveel

Removed condition that threw this exception, added extra tests

@firebird-issue-importer
Copy link
Author

Modified by: @mrotteveel

status: Open [ 1 ] => Resolved [ 5 ]

resolution: Fixed [ 1 ]

@firebird-issue-importer
Copy link
Author

Modified by: @mrotteveel

status: Resolved [ 5 ] => Closed [ 6 ]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment