Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Load character sets on-demand, not on initialization [JDBC495] #533

Closed
firebird-issue-importer opened this issue May 25, 2017 · 5 comments
Closed

Comments

@firebird-issue-importer

Submitted by: @mrotteveel

As reported by Hugo Larson on Firebird-java, when using Jaybird 3 in a (large) application compiled with Excelsior Jet, the initialization of the default EncodingFactory can take a long time if not all character sets are included in the compiled application (about 500ms per missing character set).

I have not been able to reproduce this behavior in Java applications running in a 'normal' JVM, but it might be worthwhile to change the character set handling to initialize on first use of a character set (if possible).

Note that including the missing character sets in the compiled Excelsior Jet application makes it fast again.

Commits: 5463983 08bdfd3 70be7eb

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented May 25, 2017

Modified by: @mrotteveel

Fix Version: Jaybird 3.0.1 [ 10831 ]

Fix Version: Jaybird 3.1 [ 10441 ]

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Jun 4, 2017

Commented by: @mrotteveel

Changed code to load character sets on-demand.

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Jun 4, 2017

Modified by: @mrotteveel

status: Open [ 1 ] => Resolved [ 5 ]

resolution: Fixed [ 1 ]

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Jun 5, 2017

Commented by: @mrotteveel

Released with Jaybird 3.0.1 : https://github.com/FirebirdSQL/jaybird/releases/tag/v3.0.1

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Jun 5, 2017

Modified by: @mrotteveel

status: Resolved [ 5 ] => Closed [ 6 ]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants