Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop requirement for connection character set on connect [JDBC502] #538

Closed
firebird-issue-importer opened this issue Jun 25, 2017 · 6 comments
Closed

Comments

@firebird-issue-importer

Submitted by: @mrotteveel

Relate to JDBC446
Replaces JDBC479

Jaybird 3.0 introduced the requirement for a connection character set being explicitly specified (JDBC446). This turns out to be rather cumbersome for users. We should drop this requirement and revert to the old default of NONE, and instead allow the system property org.firebirdsql.jdbc.defaultConnectionEncoding to override this default.

For strictness, we could opt to define a value of REJECT (eg org.firebirdsql.jdbc.defaultConnectionEncoding=REJECT), or a separate property (eg org.firebirdsql.jdbc.requireConnectionEncoding=true).

Commits: 0e484bd a708a02

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Jun 25, 2017

Modified by: @mrotteveel

Fix Version: Jaybird 3.0.2 [ 10840 ]

Fix Version: Jaybird 3.1 [ 10441 ]

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Jun 25, 2017

Modified by: @mrotteveel

Link: This issue relate to JDBC446 [ JDBC446 ]

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Jun 25, 2017

Modified by: @mrotteveel

Link: This issue replaces JDBC479 [ JDBC479 ]

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Jul 22, 2017

Commented by: @mrotteveel

Implemented. Without an explicit connection character set, Jaybird will default to NONE again. The default can be overridden with system property org.firebirdsql.jdbc.defaultConnectionEncoding with a valid Firebird character set name as value. The explicit character set requirement can be enabled by specifying system property org.firebirdsql.jdbc.requireConnectionEncoding with value true

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Jul 22, 2017

Modified by: @mrotteveel

status: Open [ 1 ] => Resolved [ 5 ]

resolution: Fixed [ 1 ]

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Aug 19, 2017

Modified by: @mrotteveel

status: Resolved [ 5 ] => Closed [ 6 ]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants