Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add explicit automatic module name to Jaybird [JDBC511] #547

Closed
firebird-issue-importer opened this issue Sep 30, 2017 · 4 comments
Closed

Add explicit automatic module name to Jaybird [JDBC511] #547

firebird-issue-importer opened this issue Sep 30, 2017 · 4 comments

Comments

@firebird-issue-importer

Submitted by: @mrotteveel

Jaybird is currently not modularized, but it would be a good idea to add an explicit automatic module name so applications using Jaybird do not need to rely on the automatic module name that is inferred from the jar filename, which is not stable depending on where you sourced Jaybird (eg jaybird or jaybird-full when download from GitHub or http://firebirdsql.org, and jaybird-jdkXX when from maven).

To set the name, add an entry Automatic-Module-Name to the manifest.

I have posted a question to the Firebird-Java mailinglist to get some input, see https://groups.yahoo.com/neo/groups/Firebird-Java/conversations/messages/11377

For this automatic module name, I see two candidates:

- org.firebirdsql.jaybird
- org.firebirdsql.jdbc.jaybird

The first is short and to the point and includes the current 'name', and could allow for logical names when breaking up Jaybird into multiple modules (eg org.firebirdsql.jdbc for the JDBC driver part, org.firebirdsql.management for the management classes, etc), while still providing a single module that exports all.

The second aligns with the maven coordinates (dropping the -jdkXX suffix), but might be a bit awkward for naming modules in the future.

Commits: 28e287a 7079566 e0b63a5 5e1bd8b f13cfbe

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Sep 30, 2017

Modified by: @mrotteveel

Fix Version: Jaybird 3.0.3 [ 10852 ]

Fix Version: Jaybird 2.2.14 [ 10820 ]

Fix Version: Jaybird 4 [ 10441 ]

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Oct 21, 2017

Commented by: @mrotteveel

The automatic module name will become org.firebirdsql.jaybird

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Oct 22, 2017

Modified by: @mrotteveel

status: Open [ 1 ] => Resolved [ 5 ]

resolution: Fixed [ 1 ]

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Jan 3, 2018

Modified by: @mrotteveel

status: Resolved [ 5 ] => Closed [ 6 ]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment