Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Firebird 4: Support for increased precision of NUMERIC and DECIMAL (DEC_FIXED) [JDBC516] #552

Closed
firebird-issue-importer opened this issue Jan 17, 2018 · 10 comments

Comments

@firebird-issue-importer

Submitted by: @mrotteveel

Jira_subtask_inward JDBC466
Is replaced by JDBC595

Firebird 4 adds increased precision up to 34 digits for NUMERIC and DECIMAL, internally called DEC_FIXED which utilizes a Decimal128 internally. Jaybird needs to add support for type DEC_FIXED, and type information should be updated (when connected to Firebird 4 or higher) to indicate the increased precision available.

Open issues: how does DEC_FIXED work with scale (eg is the Decimal128 only used to represent the integral value, or is the Decimal128 value itself scaled, and how (if at all) is the precision limited (ie does a NUMERIC(20,2) also accept a precision 34 number, or not).

Commits: 6edfc7b 1ca24ab

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Jan 17, 2018

Modified by: @mrotteveel

Fix Version: Jaybird 4 [ 10441 ]

Component: JDBC driver [ 10053 ]

description: Firebird 4 adds increased precision up to 34 digits for NUMERIC and DECIMAL, internally called DEC_FIXED which utilizes a Decimal128 internally. Jaybird needs to add support for type DEC_FIXED, and type information should be updated (when connected to Firebird 4 or higher) to indicate the increased precision available.

Open issues: how does DEC_FIXED work with scale (eg is the Decimal128 only used to represent the integral value, or is the Decimal128 value itself scaled, and how (if at all) is the precision limited (ie does a NUMERIC(20,2) also accept a precision 34 number, or not).

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Mar 31, 2018

Modified by: @mrotteveel

assignee: Mark Rotteveel [ avalanche1979 ]

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Mar 31, 2018

Commented by: @mrotteveel

Implemented

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Mar 31, 2018

Modified by: @mrotteveel

status: Open [ 1 ] => Resolved [ 5 ]

resolution: Fixed [ 1 ]

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Sep 29, 2018

Commented by: @mrotteveel

Reopened: DatabaseMetaData.getTypeInfo() needs to be modified for the larger precision supported with DEC_FIXED

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Sep 29, 2018

Modified by: @mrotteveel

status: Resolved [ 5 ] => Reopened [ 4 ]

resolution: Fixed [ 1 ] =>

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Nov 3, 2018

Commented by: @mrotteveel

Fixed getTypeInfo

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Nov 3, 2018

Modified by: @mrotteveel

status: Reopened [ 4 ] => Resolved [ 5 ]

resolution: Fixed [ 1 ]

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Sep 21, 2019

Modified by: @mrotteveel

Link: This issue is replaced by JDBC595 [ JDBC595 ]

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Mar 14, 2020

Modified by: @mrotteveel

status: Resolved [ 5 ] => Closed [ 6 ]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants