Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for the new Srp256 authentication plugin (and others) [JDBC536] #569

Closed
firebird-issue-importer opened this issue Jun 21, 2018 · 6 comments

Comments

@firebird-issue-importer

Submitted by: @mrotteveel

Depends on CORE5788

See CORE5788 and FirebirdSQL/firebird@b9a93f5

Add support for Srp256 (and possibly the other hashes (224, 384 and 512) as well).

We should consider to move JDBC417 back to Jaybird 4, to introduce a property to specify the authentication plugins to be used. That way we can minimize the number of plugins (eg only Srp256, or Srp256 + Srp), while allowing people to apply alternative combinations (eg Legacy_Auth, or Srp224, Srp384 or Srp512, etc).

Note the scope of this story is only adding support for the other protocols, and adding Srp256 to the default. Minimizing the default (eg to only Srp256) is explicitly out of scope for this ticket, and should only be done after JDBC417 is done.

Commits: 9981dbc deb844f 7e4eafa adacaff a61214b 7ad93be

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Jun 21, 2018

Modified by: @mrotteveel

Fix Version: Jaybird 3.0.5 [ 10873 ]

Fix Version: Jaybird 4 [ 10441 ]

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Jun 23, 2018

Commented by: @mrotteveel

(default) Order of plugins tried by Jaybird is Srp256,Srp,Legacy_Auth.

For Jaybird 3, only added Srp256 support. For Jaybird 4, the other SrpNNN plugins are there but can't be used until JDBC417 has been done.

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Jun 23, 2018

Commented by: @mrotteveel

The test coverage is rather light. When JDBC417 is done, additional tests need to be added that explicitly verify connecting with each plugin.

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Jun 24, 2018

Modified by: @mrotteveel

status: Open [ 1 ] => Resolved [ 5 ]

resolution: Fixed [ 1 ]

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Jun 28, 2018

Modified by: @mrotteveel

Link: This issue depends on CORE5788 [ CORE5788 ]

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Sep 7, 2018

Modified by: @mrotteveel

status: Resolved [ 5 ] => Closed [ 6 ]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants