setSavepoint() fails on dialect 1 [JDBC556]

[firebird-automations]

Submitted by: Attila Molnár (e_pluribus_unum)

JayBird 3.0.5 send SQL SAVEPOINT "ITER" with V10Database.executeImmediate(). Here getConnectionDialect() returns 1 (this is fine, and intentional) BUT the statementText already costructed by JayBird with fix dialect 3 format (quoted name)
FBSavepoint class should be dialect aware and create quoted name only in dialect 3.

This is OK with JayBird 2.9.9 : send SQL SAVEPOINT "ITER" with gds.iscDsqlExecImmed2(getIscDBHandle(), currentTr, statement, 3, null, null);

Commits: f064f63 8e1c9c4

[firebird-automations]

Commented by: @mrotteveel

Thanks for reporting; I will fix it in the next release.

[firebird-automations]

Modified by: @mrotteveel

Fix Version: Jaybird 3.0.6 [ 10883 ]

Fix Version: Jaybird 4 [ 10441 ]

[firebird-automations]

Commented by: @mrotteveel

Fix committed.

Workaround: use connection dialect 2 or 3 when connecting to a dialect 1 database (but that also influences other behavior, so use that carefully).

[firebird-automations]

Modified by: @mrotteveel

status: Open [ 1 ] => Resolved [ 5 ]

resolution: Fixed [ 1 ]

[firebird-automations]

Modified by: @mrotteveel

status: Resolved [ 5 ] => Closed [ 6 ]