Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setSavepoint() fails on dialect 1 [JDBC556] #589

Closed
firebird-issue-importer opened this issue Oct 4, 2018 · 5 comments
Closed

setSavepoint() fails on dialect 1 [JDBC556] #589

firebird-issue-importer opened this issue Oct 4, 2018 · 5 comments

Comments

@firebird-issue-importer
Copy link

@firebird-issue-importer firebird-issue-importer commented Oct 4, 2018

Submitted by: Attila Molnár (e_pluribus_unum)

JayBird 3.0.5 send SQL SAVEPOINT "ITER" with V10Database.executeImmediate(). Here getConnectionDialect() returns 1 (this is fine, and intentional) BUT the statementText already costructed by JayBird with fix dialect 3 format (quoted name)
FBSavepoint class should be dialect aware and create quoted name only in dialect 3.

This is OK with JayBird 2.9.9 : send SQL SAVEPOINT "ITER" with gds.iscDsqlExecImmed2(getIscDBHandle(), currentTr, statement, 3, null, null);

Commits: f064f63 8e1c9c4

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Oct 4, 2018

Commented by: @mrotteveel

Thanks for reporting; I will fix it in the next release.

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Oct 4, 2018

Modified by: @mrotteveel

Fix Version: Jaybird 3.0.6 [ 10883 ]

Fix Version: Jaybird 4 [ 10441 ]

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Oct 7, 2018

Commented by: @mrotteveel

Fix committed.

Workaround: use connection dialect 2 or 3 when connecting to a dialect 1 database (but that also influences other behavior, so use that carefully).

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Oct 7, 2018

Modified by: @mrotteveel

status: Open [ 1 ] => Resolved [ 5 ]

resolution: Fixed [ 1 ]

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented May 25, 2019

Modified by: @mrotteveel

status: Resolved [ 5 ] => Closed [ 6 ]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants