Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement statement timeouts of the v16 protocol using Statement.setQueryTimeout [JDBC602] #633

Closed
firebird-issue-importer opened this issue Nov 26, 2019 · 6 comments

Comments

@firebird-issue-importer

Submitted by: @mrotteveel

Add support for the v16 statement timeouts using Statement.setQueryTimeout.

Commits: 538e034 50b7044 8f7ef0b

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Nov 26, 2019

Modified by: @mrotteveel

Fix Version: Jaybird 4.0.0-beta-2 [ 10902 ]

Fix Version: Jaybird 4 [ 10441 ]

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Dec 14, 2019

Commented by: @mrotteveel

Implemented for pure-java.

Tried implementing it for native, but didn't get it to work. Leaving this ticket open for now. I will decide if support will be extended to native or not before release.

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Dec 22, 2019

Commented by: @mrotteveel

Implemented for native as well. The problem was that fbclient has an optimization where it will delay sending the execute until the first fetch.

The tests currently don't check for native client library support, but I couldn't find a way to detect this properly. I have asked on jna-users if there is a good way to detect presence or absence of a function.

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Dec 28, 2019

Commented by: @mrotteveel

Added a feature check in an invocation handler that I use to replace the default invocation handler of JNA. This feature check is then used to opt to do nothing when setting the timeout, and as a feature check in the tests.

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Dec 28, 2019

Modified by: @mrotteveel

status: Open [ 1 ] => Resolved [ 5 ]

resolution: Fixed [ 1 ]

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Jan 19, 2020

Modified by: @mrotteveel

status: Resolved [ 5 ] => Closed [ 6 ]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants