Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Firebird 4: INT128 support [JDBC624] #654

Closed
firebird-issue-importer opened this issue Jun 24, 2020 · 9 comments
Closed

Firebird 4: INT128 support [JDBC624] #654

firebird-issue-importer opened this issue Jun 24, 2020 · 9 comments

Comments

@firebird-issue-importer

Submitted by: @mrotteveel

Jira_subtask_inward JDBC466

The Int128 type is now formally exposed as type INT128, and not just as part of NUMERIC/DECIMAL with precision >= 19. Add support in the metadata for reporting this correctly.

Also make sure the backing type is a BigInteger (and not a BigDecimal).

Commits: 4347030 de64153 d6a09d5 df4f2d9

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Jun 24, 2020

Modified by: @mrotteveel

Fix Version: Jaybird 4.0.1 [ 10921 ]

Component: JDBC driver [ 10053 ]

description: The Int128 type is now formally exposed as type INT128, and not just as part of NUMERIC/DECIMAL with precision >= 19. Add support in the metadata for reporting this correctly.

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Jun 24, 2020

Modified by: @mrotteveel

description: The Int128 type is now formally exposed as type INT128, and not just as part of NUMERIC/DECIMAL with precision >= 19. Add support in the metadata for reporting this correctly. => The Int128 type is now formally exposed as type INT128, and not just as part of NUMERIC/DECIMAL with precision >= 19. Add support in the metadata for reporting this correctly.

Also make sure the backing type should be a BigInteger (and not a BigDecimal).

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Jun 24, 2020

Modified by: @mrotteveel

description: The Int128 type is now formally exposed as type INT128, and not just as part of NUMERIC/DECIMAL with precision >= 19. Add support in the metadata for reporting this correctly.

Also make sure the backing type should be a BigInteger (and not a BigDecimal).

=>

The Int128 type is now formally exposed as type INT128, and not just as part of NUMERIC/DECIMAL with precision >= 19. Add support in the metadata for reporting this correctly.

Also make sure the backing type is a BigInteger (and not a BigDecimal).

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Jun 24, 2020

Modified by: @mrotteveel

Fix Version: Jaybird 5 [ 10871 ]

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Jun 28, 2020

Commented by: @mrotteveel

On further consideration, it would probably be better to identify INT128 as Types.NUMERIC or Types.DECIMAL and let the default type be BigDecimal, that would allow it to be transparently used by other tools.

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Jul 2, 2020

Commented by: @mrotteveel

Implemented

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Jul 2, 2020

Modified by: @mrotteveel

status: Open [ 1 ] => Resolved [ 5 ]

resolution: Fixed [ 1 ]

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Aug 11, 2020

Modified by: @mrotteveel

status: Resolved [ 5 ] => Closed [ 6 ]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants