Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use 2020-01-01 for derivation of OffsetTime of TIME WITH TIME ZONE value with named zone [JDBC629] #659

Closed
firebird-issue-importer opened this issue Jul 18, 2020 · 4 comments

Comments

@firebird-issue-importer

Submitted by: @mrotteveel

Jira_subtask_inward JDBC622

Firebird 4 just before beta 2 changed how it derived the base UTC time for a named zone, by always using 2020-01-01. To make sure values in Jaybird are consistent, it must also use 2020-01-01 when deriving the value of a java.time.OffsetTime. Do be aware that this means the derived offset value is as it applies at 2020-01-01, so for example '20:58:00 Europe/Amsterdam' will be '20:58:00+01:00', even if the value is derived on a date during summertime. Especially when using CURRENT_TIME, this may yield confusing results.

See also jdp-2020-06 OffsetTime derivation for named zone (https://github.com/FirebirdSQL/jaybird/blob/master/devdoc/jdp/jdp-2020-06-offsettime-derivation-for-named-zone.md)

Commits: 3b0a97b

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Jul 18, 2020

Modified by: @mrotteveel

Fix Version: Jaybird 4.0.1 [ 10921 ]

Fix Version: Jaybird 5 [ 10871 ]

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Jul 18, 2020

Modified by: @mrotteveel

description: Firebird 4 just before beta 2 changed how it derived the base UTC time for a named zone, by always using 2020-01-01. To make sure values in Jaybird are consistent, it must also use 2020-01-01 when deriving the value of a java.time.OffsetTime. Do be aware that this means the derived offset value is as it applies at 2020-01-01, so for example '20:58:00 Europe/Amsterdam' will be '20:58:00+01:00', even if the value is derived during summertime.

See also jdp-2020-06 OffsetTime derivation for named zone (https://github.com/FirebirdSQL/jaybird/blob/master/devdoc/jdp/jdp-2020-06-offsettime-derivation-for-named-zone.md)

=>

Firebird 4 just before beta 2 changed how it derived the base UTC time for a named zone, by always using 2020-01-01. To make sure values in Jaybird are consistent, it must also use 2020-01-01 when deriving the value of a java.time.OffsetTime. Do be aware that this means the derived offset value is as it applies at 2020-01-01, so for example '20:58:00 Europe/Amsterdam' will be '20:58:00+01:00', even if the value is derived on a date during summertime. Especially when using CURRENT_TIME, this may yield confusing results.

See also jdp-2020-06 OffsetTime derivation for named zone (https://github.com/FirebirdSQL/jaybird/blob/master/devdoc/jdp/jdp-2020-06-offsettime-derivation-for-named-zone.md)

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Jul 25, 2020

Modified by: @mrotteveel

status: Open [ 1 ] => Resolved [ 5 ]

resolution: Fixed [ 1 ]

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Aug 11, 2020

Modified by: @mrotteveel

status: Resolved [ 5 ] => Closed [ 6 ]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants