Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimization of ResultSet.next() [JDBC633] #663

Closed
firebird-automations opened this issue Sep 5, 2020 · 3 comments
Closed

Optimization of ResultSet.next() [JDBC633] #663

firebird-automations opened this issue Sep 5, 2020 · 3 comments
Assignees
@mrotteveel
Labels
component: jdbc driver fix-version: Jaybird 5 priority: major type: improvement

Comments

@firebird-automations
Copy link

Submitted by: @mrotteveel

Only attempting to close fields that are actually closeable provides a minor performance improvement for calls to `ResultSet.next()` (very simple profiling showed 3-5% for non-cached TYPE_FORWARD_ONLY, 80-90% for cached/scrollable).

Pull request: #34

Commits: 1f55d28
@firebird-automations
Copy link
Author

Modified by: @mrotteveel

Fix Version: Jaybird 5 [ 10871 ]

@firebird-automations
Copy link
Author

Commented by: @mrotteveel

Pull request merged. Needs to be documented in release notes.

mrotteveel added a commit that referenced this issue Oct 17, 2021
@mrotteveel
#663 Document optimization of ResultSet.next() in release notes
5d656a5
@mrotteveel
Copy link
Member

Documented in release notes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mrotteveel mrotteveel

Labels
component: jdbc driver fix-version: Jaybird 5 priority: major type: improvement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mrotteveel @firebird-automations