Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Investigate difference between FBStatement and FBPreparedStatement internalExecute #681

Closed
mrotteveel opened this issue Oct 18, 2021 · 1 comment
Closed

Investigate difference between FBStatement and FBPreparedStatement internalExecute #681

mrotteveel opened this issue Oct 18, 2021 · 1 comment
Assignees
@mrotteveel
Labels
component: jdbc driver fix-version: Jaybird 5 type: task

Comments

@mrotteveel
Copy link
Member

The method AbstractFBPreparedStatement.internalExecute(boolean) will reset currentStatementResult to StatementResult.NO_MORE_RESULTS, while FBStatement.internalExecute(String) doesn't. The behaviour of FBPreparedStatement seems to be the right behaviour to me, but TestFBStatement.verifySingletonStatementWithException() explicitly tests for this behaviour.

Investigate the difference, and - if possible - ensure both behave the same.
mrotteveel added a commit that referenced this issue Aug 29, 2022
@mrotteveel
#681 Fix inconsistency in update count after execute error
04cf066
@mrotteveel mrotteveel self-assigned this Aug 29, 2022
@mrotteveel
Copy link
Member Author

Conclusion stands, changed to set currentStatementResult to StatementResult.NO_MORE_RESULTS also for FBStatement (and FBCallableStatement) code paths. This means after an exception, retrieval of update counts (with Statement.getUpdateCounts()) will return -1 for all Statement implementations, not just FBPreparedStatement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mrotteveel mrotteveel

Labels
component: jdbc driver fix-version: Jaybird 5 type: task
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mrotteveel