Right After OnLoadStart in __LoadScenes Method, Client Does Not Handle Moving Objects Correctly

[Katerlad]

Two issues with this same section of code.
See Discord Thread: https://discord.com/channels/424284635074134018/1057712730557132813

Suspect Code:

            /* Before unloading if !asServer and !asHost and replacing scenes
             * then move all non scene networked objects to the moved
             * objects holder. Otherwise network objects would get destroyed
             * on the scene change and never respawned if server doesn't
             * have a reason to update visibility. */
            if (!data.AsServer && !asHost && (replaceScenes != ReplaceOption.None))
            {
                Scene s = GetMovedObjectsScene();
                foreach (NetworkObject nob in _networkManager.ClientManager.Objects.Spawned.Values)
                {
                    if (!nob.IsSceneObject)
                        UnitySceneManager.MoveGameObjectToScene(nob.gameObject, s);
                }
            }

1. !!!!Client doesn't consider Nested Objects before moving them into the MovedObjectsScene if replace option is not ReplaceOption.none!!!!!

• Host/Server Seems to handle the movement of nested nobs properly, however it breaks on the client and debugging seems to point to this section of code.

2. Client doesn't consider DDOL objects before moving them into the MovedObjectsScene.

• This section of the method takes all Spawned Objects on the client and moves them into the moved object scene before deciding to keep them or not. Doesn't necessarily break anything but for organization there should be a check to keep objects in DDOL IMO.

[Katerlad]

            /* Before unloading if !asServer and !asHost and replacing scenes
             * then move all non scene networked objects to the moved
             * objects holder. Otherwise network objects would get destroyed
             * on the scene change and never respawned if server doesn't
             * have a reason to update visibility. */
            if (!data.AsServer && !asHost && (replaceScenes != ReplaceOption.None))
            {
                Scene s = GetMovedObjectsScene();
                foreach (NetworkObject nob in _networkManager.ClientManager.Objects.Spawned.Values)
                {

                    if (!nob.IsSceneObject && !nob.IsNested) // <------- Added a check for isNested and it seems to have fixed the 
                    // problem however no extensive testing has been done.
                        UnitySceneManager.MoveGameObjectToScene(nob.gameObject, s);
                }
            }
          

See comment in code for potential fix for problem number 1.

[Katerlad]

I am Silly, didnt realize you could do the IsGlobal Check as well and solve both issues

again not extensively tested but added the two checks extra to end up with this code below. Which seems to fix both problems.

            /* Before unloading if !asServer and !asHost and replacing scenes
             * then move all non scene networked objects to the moved
             * objects holder. Otherwise network objects would get destroyed
             * on the scene change and never respawned if server doesn't
             * have a reason to update visibility. */
            if (!data.AsServer && !asHost && (replaceScenes != ReplaceOption.None))
            {
                Scene s = GetMovedObjectsScene();
                foreach (NetworkObject nob in _networkManager.ClientManager.Objects.Spawned.Values)
                {

                    if (!nob.IsSceneObject && !nob.IsNested && !nob.IsGlobal) // <-- Added a check for isNested and isGlobal
                     //and it seems to have fixed the problem however no extensive testing has been done.
                        UnitySceneManager.MoveGameObjectToScene(nob.gameObject, s);
                }
            }

[FirstGearGames]

Thanks for the investigation. This seems pretty straight forward so I'll try to get it in immediately after 3.1.1

[FirstGearGames]

I actually just updated the CanMoveNetworkObject method and call that

[Katerlad]

🔥 sounds good!, I was gonna say that but was worried that would log a warning for every invalid object in the list. So I kinda figured that method was for users who were manually moving gameobjects and not FishNet Internal functions moving gameobjects.

[FirstGearGames]

It would. I changed the method to this private bool CanMoveNetworkObject(NetworkObject nob, bool warn)
It only warns now for the user specified ones, not the ones it auto moves.

[Katerlad]

Boom! that will do it :)