From bd6a3d12024648d6bafd82771d561300b063f9c6 Mon Sep 17 00:00:00 2001 From: Jeremiah Senkpiel Date: Mon, 23 Sep 2019 11:34:20 -0700 Subject: [PATCH] fixup: always use destroy(err) instead of emit See https://github.com/nodejs/node/pull/29653 --- helpers/readable-sink.js | 4 ++-- helpers/writable-source.js | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/helpers/readable-sink.js b/helpers/readable-sink.js index efe24cc..6992be0 100644 --- a/helpers/readable-sink.js +++ b/helpers/readable-sink.js @@ -84,7 +84,7 @@ class ReadableSink extends Readable { if (error !== null) { if (this[kErrored] === false) { this[kErrored] = true - process.nextTick(_ => this.emit('error', error)) + this.destory(error) } return } @@ -111,7 +111,7 @@ class ReadableSink extends Readable { // If we get to here something is very wrong. error = new Error(`ReadableSink: Invalid status without an error: ${status}`) - process.nextTick(_ => this.emit('error', error)) + this.destory(error) } } diff --git a/helpers/writable-source.js b/helpers/writable-source.js index be93e2e..a67734a 100644 --- a/helpers/writable-source.js +++ b/helpers/writable-source.js @@ -48,7 +48,7 @@ class WritableSource extends Writable { if (this[kFinalCallback] === null) { // _write should not have happened. const error = new Error('write happened but stream was ended without a final callback') - process.nextTick(_ => this.emit('error', error)) + this.destory(error) } return }