Jeremiah Senkpiel
Fishrock123

Organizations

@koajs @expressjs @repo-utils @crypto-utils @node-forward @jshttp @pillarjs @nodejs
Jul 28, 2016
Fishrock123 commented on issue nodejs/node#7904
@Fishrock123

V6 LTS doesn't need to release until mid-way through october somewhere though.

Jul 28, 2016
Fishrock123 commented on issue nodejs/node#7904
@Fishrock123

¯\_(ツ)_/¯ as @targos says it'l only be around just over a half a year.

Jul 13, 2016
Fishrock123 commented on pull request nodejs/LTS#121
@Fishrock123

I think we should define ABI.

Jul 13, 2016
Fishrock123 commented on pull request nodejs/LTS#121
@Fishrock123

Should also have some sort if definition of minors we backport, maybe?

Jul 13, 2016
Fishrock123 commented on pull request nodejs/LTS#121
@Fishrock123

Maintenance branches should never receive minors except for major security issues.

Jul 13, 2016
Fishrock123 commented on pull request nodejs/LTS#121
@Fishrock123

remove -style, imo. "Maintenance" with quotes should do.

Jul 13, 2016
Fishrock123 commented on pull request nodejs/LTS#121
@Fishrock123

I still think this should be "Maintenance" (non-LTS)

Jul 13, 2016
Fishrock123 commented on pull request nodejs/node#7690
@Fishrock123

Seems reasonable to me, I bet core will need it at some point in the future. CI: https://ci.nodejs.org/job/node-test-pull-request/3282/

Jul 13, 2016
Fishrock123 commented on pull request nodejs/node#7635
@Fishrock123

I think so

Jul 12, 2016
Fishrock123 commented on pull request nodejs/node#6436
@Fishrock123

@TheAlphaNerd if it cleanly applies you should be able to land it

Jul 12, 2016
Fishrock123 commented on pull request nodejs/node#7613
@Fishrock123

@TheAlphaNerd You'd also need to backport 88804b8 The test should pass. Maybe that entire PR should be backported? unsure

Jul 12, 2016
Fishrock123 commented on pull request nodejs/node#7165
@Fishrock123

Correct

Jul 12, 2016
Fishrock123 commented on issue nodejs/build#367
@Fishrock123

Any progress here?

Jul 12, 2016
Fishrock123 commented on pull request nodejs/node#7625
@Fishrock123

lgtm as a first step

Jul 12, 2016
Fishrock123 commented on issue nodejs/node#7614
@Fishrock123

If anyone takes this up, you can probably just delete the test, I think.

Jul 12, 2016
Fishrock123 commented on pull request nodejs/node#7670
@Fishrock123

LGTM

Jul 12, 2016
Fishrock123 commented on pull request nodejs/node#7165
@Fishrock123

We should probably only do this where we need to modify it, otherwise there will be a hit to each call

Jul 12, 2016
Fishrock123 commented on issue nodejs/node#7665
@Fishrock123

We should do this with or without .editor support.

Jul 11, 2016
Jul 11, 2016
Fishrock123 commented on pull request nodejs/node#3063
@Fishrock123

Also make sure you link to the original PR and maybe say it is a port of sorts from that commit

Jul 11, 2016
Fishrock123 commented on pull request nodejs/node#3063
@Fishrock123

Commit message needs updating. LGTM with nits fixed

Jul 11, 2016
Fishrock123 commented on pull request nodejs/node#3063
@Fishrock123

A little comment on what is going on here would be preferred then

Jul 11, 2016
Fishrock123 commented on pull request nodejs/node#7548
@Fishrock123

@trevnorris Lots of failures. :/

Jul 11, 2016
Fishrock123 commented on pull request nodejs/node#6816
@Fishrock123

Correctly outputting all stdio data upon node exiting by uncaught exception or process.exit() should be the primary consideration. @kzc Unfortuna…

Jul 11, 2016
Fishrock123 commented on pull request nodejs/node#7360
@Fishrock123

@cjihrig Hmmm, I like the timer check here tbh. I think _getActiveHandles() will be hard to filter though since there will also be process.stdout a…

Jul 11, 2016
Fishrock123 commented on pull request nodejs/node#7360
Jul 11, 2016
Fishrock123 commented on pull request nodejs/node#7360
@Fishrock123

If not, const and an arrow function here would be appriciated

Jul 11, 2016
Fishrock123 commented on pull request nodejs/node#7360
@Fishrock123

Maybe this is nitpicking but I'd feel better about testing this with an internal timer: const timers = require('timers'); // ... const timer = { _o…