From 7935500804426d79820203d833f2184b29fd418b Mon Sep 17 00:00:00 2001 From: Novak Zaballa Date: Mon, 24 Jul 2023 11:54:47 -0400 Subject: [PATCH 1/2] Add 10 secs by default to timeoutSeconds --- sdk/index.ts | 2 +- sdk/utils.ts | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/sdk/index.ts b/sdk/index.ts index 17669ed..3b4c1b7 100644 --- a/sdk/index.ts +++ b/sdk/index.ts @@ -30,7 +30,7 @@ export class Flagsmith { environmentKey?: string; apiUrl: string = DEFAULT_API_URL; customHeaders?: { [key: string]: any }; - requestTimeoutSeconds?: number; + requestTimeoutSeconds?: number = 10; agent: RequestInit['agent']; requestTimeoutMs?: number; enableLocalEvaluation?: boolean = false; diff --git a/sdk/utils.ts b/sdk/utils.ts index 1b1fbf7..48156d6 100644 --- a/sdk/utils.ts +++ b/sdk/utils.ts @@ -19,8 +19,8 @@ export const delay = (ms: number) => export const retryFetch = ( url: string, fetchOptions: RequestInit, - retries = 3, - timeout?: number // set an overall timeout for this function + retries: number = 3, + timeout?: number = 10// set an overall timeout for this function ): Promise => { return new Promise((resolve, reject) => { const retryWrapper = (n: number) => { From 0f0925a1ec27b46363ececccfcfc139248994009 Mon Sep 17 00:00:00 2001 From: Novak Zaballa Date: Mon, 24 Jul 2023 12:32:50 -0400 Subject: [PATCH 2/2] Remove question mark --- sdk/utils.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sdk/utils.ts b/sdk/utils.ts index 48156d6..3964b21 100644 --- a/sdk/utils.ts +++ b/sdk/utils.ts @@ -20,7 +20,7 @@ export const retryFetch = ( url: string, fetchOptions: RequestInit, retries: number = 3, - timeout?: number = 10// set an overall timeout for this function + timeout: number = 10// set an overall timeout for this function ): Promise => { return new Promise((resolve, reject) => { const retryWrapper = (n: number) => {