Skip to content

Conversation

@emyller
Copy link
Contributor

@emyller emyller commented Nov 13, 2025

Environment flags return only environment defaults, excluding segment-based targeting.

See Flagsmith/flagsmith#6051.

Changes

  • Modify getEnvironmentFlagsFromLocalEvaluationContext() to omit segments from evaluation context
  • Add test verifying environment flags ignore segments while identity flags respect them
  • Add test fixture with segment matching environment-level context

Closes #116

Review effort: 1/5

Co-authored-by: Claude <noreply@anthropic.com>
@emyller emyller requested a review from a team as a code owner November 13, 2025 20:19
@emyller emyller requested review from gagantrivedi and removed request for a team November 13, 2025 20:19
@emyller emyller changed the title fix(Flagsmith): Omit segments from environment flags evaluation fix(Local Evaluation): Omit segments from environment flags evaluation Nov 13, 2025
@emyller emyller self-assigned this Nov 13, 2025
@emyller emyller merged commit 9e459f5 into main Nov 14, 2025
7 checks passed
@emyller emyller deleted the fix/client/omit-segments-from-environment-flags branch November 14, 2025 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

getEnvironmentFlags includes segments in evaluation context

3 participants