fix(frontend): prevent error when inputRef is undefined#7649
Conversation
|
@afsuyadi is attempting to deploy a commit to the Flagsmith Team on Vercel. A member of the Team first needs to authorize it. |
There was a problem hiding this comment.
Code Review
This pull request updates the focus logic in CreateOrganisationPage.tsx to safely check if the focus method exists before calling it. The reviewer suggests using optional chaining (inputRef.current?.focus?.()) as a cleaner, more idiomatic alternative to the verbose if statement and typeof check.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
talissoncosta
left a comment
There was a problem hiding this comment.
Approving! thanks for this, and for the really clear description and repro video! 🙌
Thanks for contributing! 🚀
|
No Prob. Please do mention me if you need any help, I would gladly contribute. 👍 @talissoncosta |
Thanks for submitting a PR! Please check the boxes below:
docs/if required so people know about the feature.Changes
Contributes to #7537
It's a problem that happens inside useEffect hook. This hook is used to help the page to focus the screen on a certain HTML element using useRef hook, which is assigned to inputRef.
We can see that the n.input is undefined when it's trying to execute method focus, so the inputRef has not been set. To prevent this from happening, I propose an explicit check to verify that:
How did you test this code?
Video:
Screencast.from.30-05-26.17.40.29.webm