Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flank should not skip tests annotated with @Ignored #648

Merged
merged 2 commits into from Mar 5, 2020

Conversation

@pawelpasterz
Copy link
Collaborator

pawelpasterz commented Mar 3, 2020

Fixes #629

Changes

  • tests annotated with @Ignore are included in test matrix by default (TL skips them anyway)
  • user still can filter tests with @Ignore with notAnnotation org.junit.Ignore
  • Ignored tests now have time = 0 (regardless previous results)
  • update and refactor unit tests

Checklist

  • Documented
  • Unit tested
@pawelpasterz pawelpasterz requested review from bootstraponline and jan-gogo Mar 3, 2020
@bootstraponline

This comment has been minimized.

Copy link
Contributor

bootstraponline commented Mar 4, 2020

If we know a test is ignored, we probably want to assign it a runtime of 0 when packing shards by time.

@pawelpasterz

This comment has been minimized.

Copy link
Collaborator Author

pawelpasterz commented Mar 4, 2020

If we know a test is ignored, we probably want to assign it a runtime of 0 when packing shards by time.

Nice catch! Thanks for pointing this out

Pawel Pasterz
@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Mar 4, 2020

Codecov Report

❗️ No coverage uploaded for pull request base (master@4102e5e). Click here to learn what that means.
The diff coverage is 88.23%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #648   +/-   ##
=========================================
  Coverage          ?   77.53%           
  Complexity        ?      633           
=========================================
  Files             ?       86           
  Lines             ?     2520           
  Branches          ?      323           
=========================================
  Hits              ?     1954           
  Misses            ?      360           
  Partials          ?      206
@pawelpasterz pawelpasterz merged commit fc31d55 into master Mar 5, 2020
1 check passed
1 check passed
Bitrise Summary
Details
@pawelpasterz pawelpasterz deleted the ignored-test-included-in-results branch Mar 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

4 participants
You can’t perform that action at this time.