Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip Bugsnag initialisation if user disabled gcloud analytics #678

Merged
merged 1 commit into from Mar 23, 2020

Conversation

@pawelpasterz
Copy link
Collaborator

pawelpasterz commented Mar 20, 2020

Fixes #581

Changes

  • Introduce BugsnagInitHelper class to handle Bugsnag initialisation logic
  • if useMock is equal true -- Bugsnag is not enabled
  • if user had disabled gcloud analytics -- Bugsnag is not enabled
  • in other cases -- Bugsnag enabled
  • Add updateFlank gradle task to update local flank jar
  • Add mockk library as POC (will replace mockito in the future)

Checklist

  • Documented
  • Unit tested
  • release_notes.md updated
@pawelpasterz pawelpasterz added this to the May 2020 milestone Mar 20, 2020

private const val GSUTIL_FOLDER = ".gsutil"
private const val ANALYTICS_FILE = "analytics-uuid"
private const val DISABLED = "DISABLED\n"

This comment has been minimized.

Copy link
@doodla

doodla Mar 22, 2020

Collaborator

Why is there a new line at the end?

This comment has been minimized.

Copy link
@pawelpasterz

pawelpasterz Mar 22, 2020

Author Collaborator

This file can be added manually by the user. Since some of text editors add new line char at the end of text file automatically I wanted to simulate that case.

@doodla

This comment has been minimized.

Copy link
Collaborator

doodla commented Mar 22, 2020

@pawelpasterz pawelpasterz merged commit 3a27b3b into master Mar 23, 2020
3 checks passed
3 checks passed
Validation
Details
Validation
Details
Bitrise Summary
Details
@pawelpasterz pawelpasterz deleted the respect-gcloud-analytics-opt-out branch Mar 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

4 participants
You can’t perform that action at this time.